code review diffs look like this

Loading diff...

QA testing:

• Create grade items via assignment and add them to a weighted gradebook category. This will test cases where the grade item percentage weight is null

• Test conditions where you try to manually equally weight categories:

  • and then assign grades (89.995) to each item and see if the course grade stays at 90

    • e.g. HW1 - HW4, each having 25% weight, assigning grades to only 3 results in a 1/3 situation (0.25 / 0.75 = 0.333333)

  • and assign 0 weights to items and enter 89.995 for one after another

  • uncheck "Include in grade:" and see how this behaves

• Try this with EC items in a normal category as well as with EC category

The case that concerns me is an EC category w/o equal weight. SO i created:

-Cat 1 100% Non Ec
– Item 1 100% Non EC "Give Ungraded no credit"
-EC CAT 100% EC Category
– EC 1 (25%)
– EC 2 (25%)
– EC 3 (25%)
– EC 4 (25%)

Set up the 89.995 tree and all looked good with both EC scaling and no EC scaling.

added UCD code review: https://crucible.ucdavis.edu/cru/CR-SAK-54

We also noticed an issue where the equally weighted code wasn't handling items with null unit weight. the fix for this is in r73005.