We should not use HALF_EVEN rounding mode in display and grade lookup code.

Description

Functional Description: See functional description of https://sakaiproject.atlassian.net/browse/GRBK-780#icft=GRBK-780

We should not use HALF_EVEN rounding modes in display and grade lookup code.

This needs to be changed to HALF_UP.

Attachments

1
  • 04 Nov 2010, 02:20 PM

Activity

Show:

Jon Gorrono April 9, 2011 at 10:06 PM

ok, let me put that in another way: half_even errors would be tested by using values that we know will produce errors under a half_even rounding scenerio.. and AFAICS, we haven't given qa any numbers like that, have we? Yet another way: surfacing half_even rounding errors the way we would get them would be hard to do, no? Given that... should we test the exact numbers we need to produce half_even rounding errors (in the old code) in order to show that there is not longer errors? Or are we good with just getting good numbers for variously scaled numbers as Nancy has done?

Jon Gorrono April 4, 2011 at 5:43 PM

I don't know that this really tested anything about half_even rounding per se. To do that we would need to be much much more precise with a QA test plan... But if the plan was to make sure we didn't create new trouble by fixing the it, then I think the test is good enuf.

Michael Wenk January 27, 2011 at 3:35 PM

I agree that it is sufficient testing.

Thomas Amsler January 25, 2011 at 3:06 PM
Edited

Looks like sufficient testing. What do others think?

Nancy Wilkison January 19, 2011 at 11:27 AM

SmartSite@UCDavis - 2.6.4.2 - Sakai 2.6.2 - Server "ucddev1"
gb2 v1.4.0-a4

TEST PROCESS
site DDD 123 123 w11, category, points, weighted by points
1 - have multiple items, assorted point values, multiple participants
2 - graded single items with varying point values, @ variety of scores, and checked course grade rounded as expected
3 - graded multiple items of equal weight (same point value) @ a variety of scores/items, for the same person, and verified course grade rounding
I can provide scores if needed but it's really boring.

once I figured out the rounding calculation method, everything rounded correctly.

I did NOT check multiple items with different weights. emailed Thomas if I need to be that obsessive.

QA RESULTS -
pass
unless I need to test more

Fixed

Details

Assignee

Reporter

Components

Fix versions

Priority

Created October 22, 2010 at 9:23 PM
Updated April 9, 2011 at 10:06 PM
Resolved February 10, 2011 at 9:48 AM