Calculation issue when having 4 grade items in a category but only 3 of them are graded

Description

  • Gradebook grade using: "Weighted Categories" points or percentage

  • Create category "Weight items equally" disabled

  • Create 4 grade items in that category

  • Grade 3 grade items giving each 89.995

The course grade turnes out to be 89.99 instead of 90.00

Attachments

3

Activity

Show:

Jon Gorrono March 3, 2011 at 11:58 AM

code review diffs look like this

Loading diff...

Thomas Amsler March 3, 2011 at 9:27 AM

QA testing:

  • Create grade items via assignment and add them to a weighted gradebook category. This will test cases where the grade item percentage weight is null

  • Test conditions where you try to manually equally weight categories:

    • and then assign grades (89.995) to each item and see if the course grade stays at 90

      • e.g. HW1 - HW4, each having 25% weight, assigning grades to only 3 results in a 1/3 situation (0.25 / 0.75 = 0.333333)

    • and assign 0 weights to items and enter 89.995 for one after another

    • uncheck "Include in grade:" and see how this behaves

  • Try this with EC items in a normal category as well as with EC category

Michael Wenk March 2, 2011 at 7:42 PM

The case that concerns me is an EC category w/o equal weight. SO i created:

-Cat 1 100% Non Ec
– Item 1 100% Non EC "Give Ungraded no credit"
-EC CAT 100% EC Category
– EC 1 (25%)
– EC 2 (25%)
– EC 3 (25%)
– EC 4 (25%)

Set up the 89.995 tree and all looked good with both EC scaling and no EC scaling.

Michael Wenk March 2, 2011 at 7:38 PM

Michael Wenk March 2, 2011 at 7:37 PM

We also noticed an issue where the equally weighted code wasn't handling items with null unit weight. the fix for this is in r73005.

Fixed

Details

Assignee

Reporter

Components

Fix versions

Priority

Created February 28, 2011 at 1:26 PM
Updated March 5, 2011 at 12:11 AM
Resolved March 2, 2011 at 9:41 PM