I'm curious what the goals of this fix were.

The fix and the property that was introduced only hides the root folder; the change doesn't protect any of the folders or content deeper in Resources. Therefore, if an instructor links to or embeds a file somewhere in the site that is located deeper than the root of Resources and hides Resources, a student can still get to any of the other (non-hidden) files and folders in Resources by removing the file name from the file's path to reveal the Resources tool's simplified directory view, which doesn't adequately protect the rest of the files in Resources.

To address this properly, all folders in Resources that were originally set to "Show this folder" prior to hiding the Resources tool should be set to "Hide this folder but allow access to its contents" when the Resources tool is hidden. This would protect the file structure in Resources from being viewed by students when Resources is hidden, while still allowing files to be used elsewhere in the site.

Another side effect I've noticed of this, if this feature is enabled on the server, there's no way to change the resources tool top level. Like for instance if you wanted it completely hidden (or for some reason visible) there's no way to edit the availability on the top level folder! It looks like this was an old unfulfilled jira on SAK-14068. I'm not sure why this was never resolved . . . I think I'll re-open that older jira.

Marked as verified based on comment. isn't in 11 so I'm not sure of the side effect from that feature. . . It might not be easy to fix though though it seems like if you only hide the root level folder you could still be able to see into the files AND folders enclosed. I created about this.

I tested on nightly experimental, and it seems to be working well.

Here are my testing steps and results:

• As instructor, created 2 sites with Resources tool enabled. In each site put some folders and files in Resources.

• In site 1, went to Site Info > Tool Order, and "hid" Resources (i.e. made it invisible to students). In site 2, left Resources visible to students.

• Logged in as student who is enrolled in both sites. On Home page, clicked on Resources, and at the bottom clicked "Copy Content from My Other Sites". Student can see Resources from site 2 but cannot see Resources from site 1. Good.

• Also, tested when student goes into either of these sites and attaches a document in forums or assignments. When attaching, if the student clicks option to "select files from workspace or site", he sees only Resources from Site 2. Good.

I noticed one problem, which may belong on another jira...

• Nightly experimental has a new feature that allows instructors to "Add Resources Folder" to a Lessons page (see ).

• When the Resources tool is made invisible to students ("special hidden"), and a Resources folder is added to Lessons using this new feature, the contents of the folder cannot be viewed by the student in Lessons. This is inconsistent with the existing "Add Content Links" feature in Lessons – which lets instructors create a link to a file in Resources, and that file is available to students, even if Resources is special hidden. See attached screenshots.

• These two Lessons features should treat "special hidden" Resources folders and files the same. From a T&L perspective, it's desirable to hide Resources on the course menu but still allow students access to selected Resources folders and files via Lessons.

I set the property for nightly experimental so it should be set after the next restart