Textarea > obey Resources tool visibility in elFinder

Description

Currently, if you hide an uploaded file or folder in the Resources tool, that file/folder will not appear for students when using the 'Browse Server' method to link to files on the server.

However, if you hide the Resources tool in entirety (Site Info > Tool Order > Make Tool Invisible to Students), all files and folders which are not explicitly hidden themselves will still be accessible to students via the 'Browse Server' method. This is counter intuitive, as the the typical use case for hiding the Resources tool from students is so that they cannot access the files and folders within, without the need to go into each file and folder individually and set them to be hidden.

The linked PR alters the textarea code to check if the Resources tool is hidden. If so, it will not return any file or folder entries; otherwise it returns any that are not individually hidden (original behaviour).

Activity

Show:

Brian J. July 7, 2018 at 12:27 PM
Edited

, I'm not sure the sakai.property 'poh.resources.content.sync.visibility=true' is working as intended, or possibly was never intended to solve the use case of hiding files in Resources via elFinder.

With the property set to 'true', as a student when I use 'Browse Server' I am still able to see all files/folders in the Resources tool which has been marked as hidden from students. There is a PermissionException thrown in the log for each file/folder in the Resources tool, but each one still shows up in the elFinder UI (with file name and all other details), and still allows me to link to it successfully.

Is this a bug with SAK-32127, or a new feature request?

EDIT: it must be something with my local setup, it's working as I expected it should on the master nightly; disregard.

Won't Fix

Details

Priority

Affects versions

Components

Assignee

Reporter

Created June 30, 2018 at 12:05 PM
Updated July 7, 2018 at 12:46 PM
Resolved July 7, 2018 at 12:46 PM