LTI Group Grading screen should look like the grading screen does for individual submissions

Description

Testing https://sakaiproject.atlassian.net/browse/SAK-48745 everything is working really well except the instructor’s grading screen. At one time when the group submissions were working well for LTI, (a very brief period before they broke again), the instructor did see the regular grading screen for the sticky grader when clicking on a group submission.

Now, the instructor has to select Student Data from the Instructor drop-down, which then lists all the students who have submitted. I only had 3 group submissions, so I could easily figure out which student needed to be graded, but in a course with 50 or 100 students and many groups, this may be very frustrating to the instructor.

This is the only issue I found. Otherwise the LTI group stuff is working well!

Just as a note, this fix introduced a bug which was later identified and fixed in https://sakaiproject.atlassian.net/browse/SAK-50429

When back-merging this make sure to also back merge https://sakaiproject.atlassian.net/browse/SAK-50429 at the same time.

Attachments

3
  • 14 Sep 2024, 08:14 PM
  • 25 Aug 2024, 11:59 PM
  • 07 Aug 2024, 11:49 PM

Activity

Show:

Andrea Schmidt September 14, 2024 at 8:14 PM

This is still not working correctly: 25x: https://trunk-maria.nightly.sakaiproject.org/, build: 1511f8f4

If each group is clicked on individually from the submissions page, the grading page loads. If the instructor tries to use the navigation, it is not working.

Bernardo Garcia Vila August 28, 2024 at 6:20 AM

Yes, sorry, it’s https://sakaiproject.atlassian.net/browse/SAK-50429 and it’s already solved.

Andrea Schmidt August 27, 2024 at 9:54 PM

should the Jira you create be linked to this one?

Bernardo Garcia Vila August 27, 2024 at 7:31 AM

I believe this is causing issues for grading non LTI submissions, I’ll file a jira

Andrea Schmidt August 25, 2024 at 11:58 PM

Tested on 25x: https://trunk-maria.nightly.sakaiproject.org/, build:fc042b24 This is still failing. The grading screen hasn’t changed, but I am seeing the following in the server logs:

25-Aug-2024 19:51:16.752 WARN [http-nio-20313-exec-76] o.s.g.i.GradingServiceImpl.getDbExternalAssignment null externalId supplied to getDbExternalAssignment. Returning empty ...

25-Aug-2024 19:51:16.765 INFO [http-nio-20313-exec-76] o.s.g.i.GradingServiceImpl.addExternalAssessment External assessment added to gradebookUid=af2ffb9a-96e2-4bd0-8bb4-dca930ffde64, externalId=/assignment/a/af2ffb9a-96e2-4bd0-8bb4-dca930ffde64/ad7cd451-6aad-4811-b971-faf7844f647d by userUid=8e286b60-5742-41f7-a008-b24730c6b0a8 from externalApp=sakai.assignment.grades

25-Aug-2024 19:51:16.773 WARN [http-nio-20313-exec-76] o.s.g.i.GradingServiceImpl.getDbExternalAssignment null externalId supplied to getDbExternalAssignment. Returning empty ...

25-Aug-2024 19:51:41.183 WARN [http-nio-20313-exec-85] o.s.a.i.SakaiSecurity.unlock unlock(): null: null asn.all.groups /site/af2ffb9a-96e2-4bd0-8bb4-dca930ffde64

Details

Priority

Affects versions

Fix versions

23 Status

Please Merge

Components

Assignee

Reporter

Environment

25x: https://trunk-maria.nightly.sakaiproject.org/, build: b7d6a0b2
Created August 7, 2024 at 11:46 PM
Updated September 14, 2024 at 8:14 PM

Flag notifications