Grader: error when loading (at least for non LTI submissions)

Description

Grader is not working when trying to grade any user, it’s just kept loading (I think that should be probably addressed too, because it doesn’t really reflect errors)

Integer contentKey = assignment.getContentId(); if (contentKey != null) { // Default assignment-wide launch to tool if there is not a SubmissionReview launch in a submission simpleAssignment.ltiGradableLaunch = "/access/lti/site/" + siteId + "/content:" + contentKey; } Map<String, Object> content = ltiService.getContent(contentKey.longValue(), site.getId());

I think all that code starting there should be inside the “if”

Activity

Show:

Andrea Schmidt August 28, 2024 at 10:30 PM

Verified on 25x: https://trunk-maria.nightly.sakaiproject.org/, build: b72a3f82

Tested both a non-lti assignment and an lti-assignment, in both a manually-created site and an official site, to make sure nothing broke. The regular assignment allows grading through the Sakai Grader, after releasing, the grade is seen by the student. I did not experience any slowness or the grader hanging up. The lti assignment needs to be graded through the lti grading page, which displays, the score is still being passed to the Sakai Grader, and after releasing, the student sees the grade.

Automation for Jira August 27, 2024 at 8:05 AM

A pull request has been created, "SAK-50429 Grader : not loading for non LTI assignments", you can see it at https://github.com/sakaiproject/sakai/pull/12826

Fixed

Details

Priority

Affects versions

Fix versions

23 Status

Please Merge

Assignee

Reporter

Created August 27, 2024 at 7:32 AM
Updated September 12, 2024 at 11:34 PM
Resolved August 27, 2024 at 3:07 PM

Flag notifications