Plus: Improve Launch Logic and use Executor Pattern For NRPS Retrieval
Description
Attachments
is related to
relates to
Activity
Andrea Schmidt December 10, 2023 at 3:09 PM
Verified on 23x: https://qa23-maria.nightly.sakaiproject.org/, build: 9ad416cc
Charles R Severance December 3, 2023 at 9:50 PM
Great and thanks. I have already started working on the non-blocker issues and am making progress - most are small and straightforward.
Andrea Schmidt December 3, 2023 at 9:20 PM
I’m going to set this to verified. I also was able to verify that the updated membership was present in the Plus site and I have not run into any new problems.
Charles R Severance December 2, 2023 at 3:00 PM
So - I could not wait so I re-tested on Master with this commit in place. I made a site, put in three students, did a launch, went in as admin added the two “speed things up” properties to the Plus site and saved it, then went back into the main site, added one user and removed one user than did another launch after a few minutes had passed - the new user was added to the Plus site and the removed user was deleted from the Plus site. I attach a log of the launch where the add and delete happenned. I look forward to you doing a more complete version of the same test on the path to “verified” for this JIRA, but I satisfied my own curiosity that that the happy path test passed for both add and delete with current master.
Automation for Jira November 21, 2023 at 5:44 PM
A pull request has been created, "SAK-49486 - Plus: Improve Launch Logic and use Executor Pattern For NRPS Retrieval", you can see it at https://github.com/sakaiproject/sakai/pull/12118
Details
Details
Priority
BlockerAffects versions
Fix versions
23 Status
Components
Assignee
Charles R SeveranceReporter
Charles R Severance
While investigating several other of the linked JIRAs, I did a detailed review and testing of the Plus "first launch" code because I thought those JIRAs were caused by my code. After all the investigation of those JIRAs it turns out the tutorial was the problem all along.
But during the review, in hopes of catching whatever error was happening, I strengthened some areas of the first launch code.
Some error messages have been improved, some error messages have been added, some extra checking has been added to catch inconsistencies in new site setup earlier, and the initial roster pull has been moved from a Thread in ProviderServlet to an Executor in the PlusServiceImpl - following the example in RefreshAuthZGroups.
So while it was working before and there is no user visible change, these changes should improve the long term performance and reliability of Plus launches.