Drag and Drop notifications go to participants that are not members of the site
Description
Activity
Sam Ottenhoff October 28, 2019 at 2:46 PM
Will Humphries wrote in 2015: "addTransientNotifcation should probably only be called once for one type of notification, within an init method."
Here is a new JIRA with a PR:
Matthew Jones October 27, 2019 at 4:39 PM
The fix is still there. It's not the exact same one suggested but it's in the same method. It looks like it wasn't resetting the file list after a drag and drop upload, and now it is.
I tested based on the test plan mentioned but I was unable to reproduce off of that.
However I don't think that this fix or the discussion between and was actually related to the initial issue I filed.
The problem I reported is that users who aren't directly members of the site were getting notifications.
The problem that was fixed was users were getting attachments for the wrong people.
So it looks like there was a problem fixed here that the problem was changed to, but not the original problem I'd filed. Was this what you're seeing now similar to that or ?
Sam Ottenhoff October 25, 2019 at 9:49 AMEdited
I believe we are seeing this issue again in Sakai 19+. Does anyone know of related JIRAs that may have reverted this fix? Or was this never fully fixed? It looks like Will Humphries diagnosed the cause of the issue but his suggested fix was never implemented
Hudson CI Server October 18, 2015 at 9:17 PM
SUCCESS: Integrated in sakai-10-java-1.7 #233 (See http://builds.sakaiproject.org:8080/job/sakai-10-java-1.7/233/)
merge PR 1141 from git (enietzel@anisakai.com: rev 321481)
Daniel Merino October 9, 2015 at 1:53 AM
Tested at https://trunk-mysql.nightly.sakaiproject.org/portal
It works fine.
SAK-27928 added a separate class for drag and drop notifications. It's been reported that users are receiving this who aren't members of a site (for instance junior admin roles like KNL-967) and it isn't filtering it to restrict to members of a site. It feels like the problem is in addSpecialRecipients as one of the methods does refine to the site users but would need a little more research.