Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Resources Drag and Drop no Email Notifications

Description

Uploading a file using the new Drag and drop feature within Resources, there is no option for the user to notify other members of the site by email. The "classic" upload screen had the option for Email Notification, and I think it should be on the Drag and Drop file upload page as well.

Attachments

2

Activity

Daniel Merino October 20, 2014 at 7:21 AM

Thanks, Sam. Verified all use cases in http://nightly2.sakaiproject.org:8085/portal

Hudson CI Server October 17, 2014 at 2:09 PM

UNSTABLE: Integrated in sakai-trunk-java-1.7 #482 (See http://builds.sakaiproject.org:8080/job/sakai-trunk-java-1.7/482/)
second patch from Daniel (ottenhoff@longsight.com: rev 314510)

Sam Ottenhoff October 17, 2014 at 9:41 AM

> OK, as you wish.

I still don't understand why we would begin changing jQuery calls to regular JavaScript calls. jQuery was created to solve cross-browser issues and to use an intuitive, functional way to modify HTML and actions. Moving to manual JS calls doesn't make sense unless your mission is to remove jQuery from the entire project.

Trunk commit r314510

Daniel Merino October 17, 2014 at 7:01 AM
Edited

OK, as you wish. I upload a new patch that fixes only the minor i18n issue, which happens also in trunk.

I hope that future backporters will read these comments, because the jQuery failure silently happens at runtime while using Dropbox tool. Is hard to find.

Sam Ottenhoff October 16, 2014 at 8:12 AM

No, I don't think it is a good change. The rest of the code uses jQuery, you should continue to use jQuery inside of the jQuery function!

Fixed

Details

Priority

Affects versions

Fix versions

Components

Assignee

Reporter

Labels

Created September 24, 2014 at 9:21 AM
Updated October 28, 2019 at 2:44 PM
Resolved October 17, 2014 at 9:41 AM