Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Can not add entity links for assignments and assessments with iSyllabus UI as a custom maintain role

Description

The iSyllabus entity link UI added with SAK-23040 does not work with custom roles. This is because the set of roles ConnectorHelper.java uses are hard coded to generic roles:

instructorRoles.add("maintain");
instructorRoles.add("Instructor");
instructorRoles.add("Owner");
instructorRoles.add("Administrator");
instructorRoles.add("Secondary Instructor");
instructorRoles.add("Teaching Assistant");

Steps to reproduce:
As an instructor/maintain user, create a site with the Assignments and Samigo.
In the new site, add one or more assignments and published assessments.
As an admin user, go to the realms tool and create a new maintain role for that site, then switch the instructor to the new role.
Back as the instructor user, navigate to a tool such as announcements and click the link tool in the ckeditor, then the "browse server" button.
The user will not be able to select entity links for assignment(s) or assessment(s).

Attachments

2

Activity

Show:

Matthew Jones January 17, 2014 at 2:42 PM

While this is fixed, thinking about it, I don't even think this should be using role checks at all. It seems like it's as bug in the original iSyllabus code that it's doing this and it should have been doing specific authz function checks instead. Checking for roles makes some assumptions that might not be correct based on the name of the role and what the user has access to, and also doesn't give someone with a lesser (but not maintain role) access to some materials that they probably should. I think that the ConnectorHelper really should be changed to not even use roles. While it technically works, I don't see how to make it work with something like Delegated access or site helper, where the user would have no role. That issue is SAK-23921.

Hudson CI Server January 7, 2014 at 6:42 PM

Integrated in kernel-trunk #749 (See http://builds.sakaiproject.org:8080/job/kernel-trunk/749/)

Result = SUCCESS

Matthew Jones January 6, 2014 at 2:27 PM

Thanks for patches, committed.

Kevin Takacs December 19, 2013 at 10:09 AM

Attaching new patch for kernel.

Aaron Zeckoski December 19, 2013 at 9:46 AM
Edited

That seems OK to me so let's go ahead with that option for now. Making the size 0 might be better than timeout zero though.

Fixed

Details

Priority

Affects versions

Fix versions

Components

Assignee

Reporter

Labels

Created June 27, 2013 at 12:56 PM
Updated June 30, 2014 at 3:37 PM
Resolved January 6, 2014 at 2:27 PM