iSyllabus NPE if user has no Role in the site
Description
Attachments
depends on
relates to
Activity
anusha allam April 25, 2014 at 9:59 AM
Ran the Test Plan on Longsight QA10. Received same error "The server didn't reply with proper XML data. Please check your configuration."
But still clicking on Ok button takes to server to link resources.
Tested at: https://qa10.longsight.com/portal
Sakai - 10-qa06 2014/04/14 - Sakai 10-qa06 (Kernel 10-qa06) - Server server59
Derek Ramsey April 22, 2014 at 9:18 AM
Verified the functionality works properly on trunk as admin user.
Matthew Jones April 19, 2014 at 7:14 PM
That's right, it's not yet merged for 10. Ideally we'd also test for linking to a Assignment and a Samigo element by both and admin and a special user (for instance a delegated access admin or a junior admin).
Maybe we can talk about that to make sure it's verified so this can get into 10.
Neal Caidin April 18, 2014 at 1:41 PMEdited
I ran through the Test Plan on Longsight QA06 and on trunk.
trunk - sakai/trunk on Oracle - Built: 04/18/14 12:00 - Sakai Revision: 308337 (Kernel 11-SNAPSHOT) - Server sakai-nightly.uits.iupui.edu
1. Created a site with Syllabus and Resource tools as instructor, non-admin
2. Add a file into Resources.
3. Logged in as admin and went to the site. In the Syllabus tool, created a link (or attempt to) to the file loaded in Resources. Worked on trunk, not on QA06.
On QA06, when trying to add the link I received the error "The server didn't reply with proper XML data. Please check your configuration." See syll_resources_xml.png .
the bottom line is it worked on trunk but not on QA06, that means this is verified correct?
Or does it mean that QA06 needs some additional configuration to make sure I am reproducing the problem correctly?
Matthew Jones April 7, 2014 at 9:25 AM
I believe it was mentioned there was some problems with the left site navigation, if you click away from the site you can't get back, but that seems like a separate issue if it does exist.
Semi related to SAK-23754 but in ConnectorHelper it makes the call
String thisUserRole = thisSite.getUserRole(loggedInUserId).getId();
If the user is an admin or delegated access, getUserRole returns null and there's an NPE. It should allow the users through as users of both these types.