Gradebook should handle group-specific Assignments with calculate course grades correctly

Integrated in edu-services trunk #558 (See http://builds.sakaiproject.org:8080/job/edu-services%20trunk/558/)
- Missed commit on for gradebook check (Revision 117416)

Result = SUCCESS

Integrated in edu-services 1.2.x #44 (See http://builds.sakaiproject.org:8080/job/edu-services%201.2.x/44/)
2.9.x merge

svn merge -c112395 https://source.sakaiproject.org/svn/edu-services/trunk/
— Merging r112395 into '.':
U gradebook-service/impl/src/java/org/sakaiproject/component/gradebook/BaseHibernateManager.java

svn log -c112395 https://source.sakaiproject.org/svn/edu-services/trunk/
------------------------------------------------------------------------ r112395 | nbotimer@unicon.net | 2012-09-13 09:11:13 -0400 (Thu, 13 Sep 2012) | 7 lines

- Fix course grades with grouped assignments

This commit is one half of the fix for this issue. It implements a method to
check the visibility of an assignment for a student and uses this to avoid
scoring inaccessible items as zero points.

------------------------------------------------------------------------
svn merge -c112396 https://source.sakaiproject.org/svn/gradebook/trunk/
— Merging r112396 into '.':
U app/sakai-tool/src/webapp/WEB-INF/spring-db.xml
U app/business/src/java/org/sakaiproject/tool/gradebook/business/impl/GradebookCalculationImpl.java
U app/ui/src/webapp/WEB-INF/spring-beans.xml

svn log -c112396 https://source.sakaiproject.org/svn/gradebook/trunk/
------------------------------------------------------------------------ r112396 | nbotimer@unicon.net | 2012-09-13 09:16:03 -0400 (Thu, 13 Sep 2012) | 13 lines

- Fix course grades with grouped assignments

This is part two of the fix. It wires up the beans so the external assessments
can be checked and checks visibility when computing the total points available
for a given student.

Note that there were some strange Spring-Hibernate transaction errors when
attempting to use the GradebookExternalAssessmentService directly, so there is
a new proxy bean for it that is marked to be non-transactional and read-only.
This is coarser-grained than I would like, but it is appropriate enough for the
need here.

------------------------------------------------------------------------ (Revision 113236)

Result = SUCCESS

r113236 - 2.9.x merge

> The course grade is not rounded, but truncated, correct?

Right, grades use the floor instead of the round. So a student who scored 89.51% in the course did not meet the 90% minimum requirement for an A-.

I did test with 500 students and 20 gradebook items. I tested on trunk.sakaiqa.org , aka http://nightly2.sakaiproject.org:8082/portal , using Mac 0S X, 10.8.1 (Mountain Lion) and a reasonable wireless internet connection, and Firefox 15. The calculations seemed right, and the performance seemed satisfactory.

The course grade is not rounded, but truncated, correct? Just checking because that is what I see with my results. The All Grades paged loaded in about 30 seconds. Is that the type of performance we are hoping to see?

Methodology.
trunk.sakaiqa.org has 500 students accounts, so it was fairly easy to add them to a course. I created three Assignments with non-electronic assignments and gradebook entries. I created 10 groups. One assignment to group 1. A second assignment to groups 2, 3, 4, 5, 6, 7,8, 9,10. A third assignment to groups 2, 4, 5. I assigned all students the same grade for each assignment.

For the other 17 gradebook columns, I uploaded a csv spreadsheet with grades. After importing, and grading the Assignments and releasing the grades, I exported the gradebook to an Excel sheet so I could compare the calculations.

Before this Jira is verified, is there anything else that needs testing? Was this the correct performance metric to review?