Damaging fix: - BaseResourceProperties has unnecessary cast in addAll() method
GENERAL
TESTING
GENERAL
TESTING
Description
This line has caused us some class cast exceptions issues due to class loading issues. It doesn't seem necessary since the getProperty method can be used instead.
request that a committer change the follow...
line 827:
Object value = ((BaseResourceProperties) other).m_props.get(name);
This issue was fixed for 2.3.0, however, there was insufficient time for QA to verify the fix before the release. As the issue has not be re-opened subsequently, we will assume the fix was correct and are closing the issue.
Megan May October 31, 2006 at 1:34 PM
in the .008 tag
Peter Knoop October 27, 2006 at 5:54 AM
This issue asks for a reversion of the change made in SAK-5386.
Megan May October 24, 2006 at 1:54 PM
changed fix version to none
Casey Dunn October 23, 2006 at 9:04 AM
This fix, which is on the tip of the 2.3 tree, removes the ability to have multi valued properties.
the getProperty(name) method does not find MV property values. When given the name of a MV property it throws a NPE.
The prior version did a raw get of the property value. This then is evaluated in the immediatly following conditional
This line has caused us some class cast exceptions issues due to class loading issues. It doesn't seem necessary since the getProperty method can be used instead.
request that a committer change the follow...
line 827:
Object value = ((BaseResourceProperties) other).m_props.get(name);
change to:
Object value = other.getProperty(name);