Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

BaseResourceProperties has unnecessary cast in addAll() method

Description

This line has caused us some class cast exceptions issues due to class loading issues. It doesn't seem necessary since the getProperty method can be used instead.

request that a committer change the follow...

line 827:

Object value = ((BaseResourceProperties) other).m_props.get(name);

change to:

Object value = other.getProperty(name);

Activity

Casey Dunn October 22, 2006 at 8:33 AM

This changes breaks addAll when a multi valued property is accessed.

getProperty is a single value accessor. When using a key for a MV property
a null is returned. the following m_props.put then throws a NPE

the brute-force get on the hashtable element gets whatever-the-hey happens
to be in the hashtable at that key.

Then the conditional has something to do.

Megan May August 2, 2006 at 4:27 PM

QA for the 2.2.0 release cycle is over. Due to resource constraints this was not formally tested. Please reopen if you find this is still a problem

Fixed

Details

Priority

Affects versions

Fix versions

Components

Assignee

Reporter

Created June 28, 2006 at 5:14 PM
Updated October 23, 2008 at 11:18 AM
Resolved June 28, 2006 at 6:55 PM