Hiding Favorites site warning shown when user attempts to hide unfavorited site

Description

Right now, when a user creates a new site it is automatically made a Favorite when it's visited the first time. If the user takes the site off of the favorites bar and then attempts to hide it in Preferences, a pop-up message is shown saying that the favorited site will be removed from the favorites toolbar if it's hidden (even though the site isn't in the favorites toolbar).

 

This pop-up warning should only display for sites that are currently in the favorites toolbar

 

 

Attachments

2

Activity

Show:

heather.valli July 22, 2022 at 2:31 PM

Verified on 21.x. ( )

Christina Schwiebert June 10, 2022 at 1:04 PM

Verified on 22.x - https://qa22-mysql.nightly.sakaiproject.org, build 81890b78. The warning appears for a favorite site, but not an unfavorite.

Daniel Merino June 3, 2022 at 12:20 PM

Automation for Jira May 27, 2022 at 12:04 PM

A pull request has been created, "SAK-44609 Hiding Favorites site warning shown when user attempts to hide unfavorited site", you can see it at https://github.com/sakaiproject/sakai/pull/10597

Steve Waldeck December 17, 2021 at 3:10 AM
Edited

While performing regression testing, I found that this issue persists also in 22x at this time – I’ve updated the Affects Versions.

Fixed

Details

Priority

Affects versions

Fix versions

22 Status

Verified

21 Status

Verified

Components

Assignee

Reporter

Labels

Environment

Chrome Version 86.0.4240.111 OS X Catalina 10.15.5
Created November 3, 2020 at 2:28 PM
Updated July 22, 2022 at 2:31 PM
Resolved May 31, 2022 at 8:43 AM