apply kernel changes for dynamic resource loader
Description
Environment
Test Plan
is depended on by
Activity
John Bush June 15, 2012 at 4:00 PM
Please see my comment in https://sakaiproject.atlassian.net/browse/KNL-925#icft=KNL-925 there is a reason.
Matthew Jones May 21, 2012 at 11:02 AMEdited
Was there some reason that MODULE_NAME was split off to be separate from BASE_NAME? It looks like in the standard resource loader all of the tools just use this value and pass their entire bundle value. But for this case it seems like you'd have a baseName which also contains the module name.
However there are some cases where the thread local manager current context wouldn't return a value (like for services?) and those resources values wouldn't be able to be overridden.
String context = (String) getThreadLocalManager().get(org.sakaiproject.util.RequestFilter.CURRENT_CONTEXT);
try
{
if (context != null) {
Map bundleValues = getMessageBundleService().getBundle(baseName, context, locale);
If it's to possibly improve the query in some cases, then it probably should be moved into MessageBundleServiceImpl.java?
if moduleName == null (don't include it in this SQL query)
String sql = "from MessageBundleProperty where baseName = ? and moduleName = ? and locale = ? and value != null";
Unless it's needed for something else I'm not seeing?
Edit: Filed this comment as https://sakaiproject.atlassian.net/browse/KNL-925#icft=KNL-925
Hudson CI Server March 21, 2011 at 10:09 PM
Integrated in sakai trunk #470 (See http://builds.sakaiproject.org:8080/job/sakai%20trunk/470/)
https://sakaiproject.atlassian.net/browse/KNL-563#icft=KNL-563 fix index.
Hudson CI Server February 23, 2011 at 9:10 PM
Integrated in sakai trunk #447 (See http://builds.sakaiproject.org:8080/job/sakai%20trunk/447/)
https://sakaiproject.atlassian.net/browse/KNL-563#icft=KNL-563 dynamic bundles index addition
SAK-20079, https://sakaiproject.atlassian.net/browse/KNL-563#icft=KNL-563 dynamic bundles additions
SAK-19088, https://sakaiproject.atlassian.net/browse/KNL-563#icft=KNL-563 update comments to include missing ticket number.
Beth Kirschner September 16, 2010 at 5:55 AM
Verified and merged to trunk
need to refactor current code to remove dependency on message service service. Going to attempt to use java's Timer utility to queue up backround processes to do the bundle indexing instead of JMS.
Turn this feature on with the following properties:
message bundle management
load.bundles.from.db=true
number of milliseconds before rechecking database for updates, the default is 30 secs
load.bundles.from.db.timeout=30000