modify sakai tools that bypass the ResourceLoader to use the ResourceLoader
Description
Environment
Test Plan
depends on
is related to
relates to
Activity
Earle Nietzel January 27, 2012 at 11:09 AM
Closing no further action needed
Earle Nietzel January 27, 2012 at 11:07 AM
This issue is now complete
Earle Nietzel January 27, 2012 at 11:05 AM
Created new issue for the last item in this list.
John Bush January 27, 2012 at 7:58 AMEdited
In that case I'd recommend we close this and create two new issues: one for samigo and one for profile2, looks like you have the profile2 one already.
Earle Nietzel January 27, 2012 at 6:56 AM
I checked through the following tools to see which ones needed to be updated, I only found samigo was missing the updated ResourceLoader
OK site-manage/site-manage-participant-helper/src/webapp/WEB-INF/applicationContext.xml
OK site-manage/site-manage-group-helper/tool/src/webapp/WEB-INF/applicationContext.xml
OK site-manage/site-manage-group-section-role-helper/tool/src/webapp/WEB-INF/applicationContext.xml
OK emailtemplateservice/tool/src/webapp/WEB-INF/applicationContext.xml
OK site-manage/pageorder/tool/src/webapp/WEB-INF/applicationContext.xml
OK polls/tool/src/webapp/WEB-INF/applicationContext.xml
OK evaluation/tool/src/webapp/WEB-INF/applicationContext.xml
UPDATE samigo/samigo-app/src/webapp/WEB-INF/applicationContext.xml
Sakai's RSF tools, and some others load message bundles directly (via a Spring ResourceLoader) this bypasses Sakai's ResourceLoader, and hence the mechanism to look in the db for values, this will need to be addressed in order to support many use cases. The applicationContext.xml generally look like this, for the problems I've found:
<bean id="messageSource"
class="org.springframework.context.support.ReloadableResourceBundleMessageSource">
<property name="basename" value="classpath:org/sakaiproject/tool/pageorder/bundle/Messages"/>
</bean>
This needs to be adjusted to this:
<bean id="messageSource"
class="org.sakaiproject.util.ResourceLoaderMessageSource">
<property name="basename" value="classpath:org/sakaiproject/site/tool/participant/bundle/sitesetupgeneric"/>
<property name="cacheSeconds" value="10" />
</bean>
from rSmart's jira here's the changes:
CLE-4418 apply messagesource loader to various tools
Files Changed
MODIFY /vendor/branches/sakai/rsmart-cle/site-manage/site-manage-participant-helper/src/webapp/WEB-INF/applicationContext.xml
MODIFY /vendor/branches/sakai/rsmart-cle/site-manage/site-manage-group-helper/tool/src/webapp/WEB-INF/applicationContext.xml
MODIFY /vendor/branches/sakai/rsmart-cle/site-manage/site-manage-group-section-role-helper/tool/src/webapp/WEB-INF/applicationContext.xml
MODIFY /vendor/branches/sakai/rsmart-cle/emailtemplateservice/tool/src/webapp/WEB-INF/applicationContext.xml
MODIFY /vendor/branches/sakai/rsmart-cle/site-manage/pageorder/tool/src/webapp/WEB-INF/applicationContext.xml
MODIFY /vendor/branches/sakai/rsmart-cle/polls/tool/src/webapp/WEB-INF/applicationContext.xml
MODIFY /vendor/branches/sakai-contrib/rsmart-cle/evaluation/tool/src/webapp/WEB-INF/applicationContext.xml
MODIFY /vendor/branches/samigo/rsmart-cle/samigo-app/src/webapp/WEB-INF/applicationContext.xml