Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Indicate when caches don't have statistics enabled.

Description

Currently the kernel shows statistical hit rates even when a cache doesn't have statistics enabled. This can be very confusing when debugging caching issues.

Attachments

3

Activity

Show:

David Horwitz June 19, 2013 at 5:55 AM
Edited

Just a note that caches created with EhCacheFactoryBean () still have statistics disabled this seems to be a spring issue that is fixed in spring 3.x when a new method:

setStatisticsEnabled

was added to the bean

David Horwitz June 19, 2013 at 5:43 AM

Testing by merging to UCT msub seems to show this patch working as expected

Hudson CI Server June 18, 2013 at 10:14 PM

Integrated in kernel-trunk #687 (See http://builds.sakaiproject.org:8080/job/kernel-trunk/687/)
Indicate when caches don't have statistics enabled
Patch from Matthew Buckett (Oxford), minor tweaks by AZ (Revision 125957)

Result = SUCCESS

Aaron Zeckoski June 18, 2013 at 9:27 PM

To test this, basically load the memory tool and view the caches, they should all have statistics listed and none should show "NO statistics (not enabled for cache)". Also, there shouldn't really be caches with 0 hits in most cases (these were likely to be ones without statistics enabled previously)

Aaron Zeckoski June 18, 2013 at 9:25 PM

Committed my adjusted patch, Thanks matthew and Oxford!
Ready for QA

Fixed

Details

Priority

Affects versions

Fix versions

Components

Assignee

Reporter

Labels

Created June 17, 2013 at 4:51 AM
Updated April 25, 2018 at 3:20 PM
Resolved June 18, 2013 at 9:25 PM