getLocalizedToolProperty should be part of ToolManager not ActiveToolManager
GENERAL
TESTING
GENERAL
TESTING
Description
ActiveToolManager builds ontop of ToolManager and adds functionality that is relavent only in a Servlet world . getLocalizedToolProperty method should be available outside the servlet world so this method should be part of the ToolManager API.
Moving this method shouldn't cause any breakages except when people implement a mock version of the ToolManager.
Although I consider this a bug, it shouldn't be backported to any stable branches as it's an API change.
This shouldn't break any existing tools as ActiveToolManager extends ToolManager. Also added some tests to check that the tool manager is working correctly and refactored some of the internal to better support testing without starting up the component manager. (Revision 107506)
Result = SUCCESS
Matthew Buckett April 24, 2012 at 6:58 AM
Fixed an added some tests to the component manager.
ActiveToolManager builds ontop of ToolManager and adds functionality that is relavent only in a Servlet world . getLocalizedToolProperty method should be available outside the servlet world so this method should be part of the ToolManager API.
Moving this method shouldn't cause any breakages except when people implement a mock version of the ToolManager.
Although I consider this a bug, it shouldn't be backported to any stable branches as it's an API change.