getLocalizedToolProperty should be part of ToolManager not ActiveToolManager
Description
is depended on by
is related to
Activity
Hudson CI Server April 24, 2012 at 1:24 PM
Integrated in kernel-trunk #504 (See http://builds.sakaiproject.org:8080/job/kernel-trunk/504/)
Add missing tool-component change to allow the kernel to start. (Revision 107530)
Result = SUCCESS
Hudson CI Server April 24, 2012 at 9:49 AM
Integrated in sitestats trunk #499 (See http://builds.sakaiproject.org:8080/job/sitestats%20trunk/499/)
Result = SUCCESS
Hudson CI Server April 24, 2012 at 7:18 AM
Integrated in kernel-trunk #502 (See http://builds.sakaiproject.org:8080/job/kernel-trunk/502/)
Move getLocalizedToolProperty to the ToolManager as it's not specific to the servlet world.
This shouldn't break any existing tools as ActiveToolManager extends ToolManager. Also added some tests to check that the tool manager is working correctly and refactored some of the internal to better support testing without starting up the component manager. (Revision 107506)
Result = SUCCESS
Matthew Buckett April 24, 2012 at 6:58 AM
Fixed an added some tests to the component manager.
ActiveToolManager builds ontop of ToolManager and adds functionality that is relavent only in a Servlet world . getLocalizedToolProperty method should be available outside the servlet world so this method should be part of the ToolManager API.
Moving this method shouldn't cause any breakages except when people implement a mock version of the ToolManager.
Although I consider this a bug, it shouldn't be backported to any stable branches as it's an API change.