Feedback Setting is not saved sometimes
Description
Attachments
incorporates
is related to
Activity
Matthew Jones September 8, 2014 at 5:21 PM
This change introduced a jQuery requirement $document.ready into authoring.js and jQuery isn't always loaded before authoring.js on every page. This causes a lot of random javascript errors now in Samigo, including this feature not working correctly.
There are a lot of ways around avoiding this method jQuery like using the following, if you don't care about IE8 (which we don't in newer versions of Sakai, or other more complex ones - http://stackoverflow.com/questions/799981/document-ready-equivalent-without-jquery)
document.addEventListener("DOMContentLoaded", function(event) {
//Do work
});
I for sure wouldn't back port it. We could also include jQuery everywhere through the header.inc () Maybe I'd just switch to that.
Raúl Sánchez Vegas May 22, 2014 at 9:17 AM
Thanks
We are going to apply these patches.
Regards,
Raúl
Yuanhua Qu May 22, 2014 at 8:48 AM
Hi, Raul
You might also want to look at Jira and SAM-2237, and apply those patches first before applying patch of this Jira. We have this on our 2.9.3 local production.
Raúl Sánchez Vegas May 22, 2014 at 7:24 AM
Hi
The patch doesn't apply in 2.9.x. Has anyone backported the patch to 2.9.x?
Thanks,
Raúl
Hudson CI Server March 20, 2014 at 4:34 AM
Integrated in sakai-10-java-1.7 #6 (See http://builds.sakaiproject.org:8080/job/sakai-10-java-1.7/6/)
SAM-2288: Feedback Setting is not saved sometimes (Revision 307259)
Result = SUCCESS
Feedback setting is not saved when previous feedback is either noFeedback or Only Release Student Score is chosen.
Here is how to reproduce it:
1. Choose nofeedback and save.
2. Edit setting again and choose any other feedback except 'noFeedback', check a few checkboxes under Release Questions and the following. Save.
3. Go back to setting again, and you will see checkboxes that checked are not saved under Release Questions.
Here is another one to reproduce:
1. Choose any feedback except nofeedback.
2. Choose Only Release Student's Assessment Scores and save.
3. Edit setting, choose Release Questions and the following and check a few checkboxes and save.
4. Go back to setting and you will see checkboxes are not checked.