Radio & Checkbox Inputs should have labels and be in fieldset

Description

Radio & Checkbox Inputs should have a label for / id association.

These should also be part of a fieldset with the question as a legend.

Here's a multiple choice test example http://www.w3.org/TR/WCAG20-TECHS/H71.html#H71-examples

Environment

None

Test Plan

None

Attachments

2

Activity

Show:

Matt Clare June 28, 2017 at 8:16 AM

Looks good on https://trunk-mysql.nightly.sakaiproject.org/portal/site/fa5442a9-2bbb-4a77-b83d-90e9d833be63/tool/75f10217-fc60-4016-bcea-2f54c038cde1/jsf/delivery/beginTakingAssessment as of Wednesday June 28, 2017

Single label for each item and radio button markup works.  This both makes Samigo more accessible for individuals who use a screen reader and anyone who'd prefer to click the text over the actual radio button.

https://brocku-my.sharepoint.com/personal/mclare_brocku_ca/_layouts/15/guestaccess.aspx?docid=16db05e43893f4794862bb2659b1fa983&authkey=AaCydNsxInT0xTyTNR2dKRk

Sam Ottenhoff June 12, 2017 at 1:37 PM

JSF 1.2 is the root cause here.

In webapps/samigo-app/jsf/delivery/item/deliverMultipleChoiceSingleCorrect.jsp, the selectOneRadio is done separately from the label and then a bunch of jQuery is responsible for glueing the radio and label back together.

I will submit another PR modifying this jQuery.

Matthew Jones June 12, 2017 at 11:58 AM

Yeah, it does like the "name" is matching up with the correct label, but the "id" is matching up with the empty label. Seems to relate to what is mentioned on SAM-3217.

Matt Clare May 24, 2017 at 1:40 PM

Fieldset looks good.

What's up with the double label tags?

I think this means there's a separate label for the name and the id, with the id being blank.

This doesn't give a very good experience with a screenreader, even playing with the focus level:
https://brocku-my.sharepoint.com/personal/mclare_brocku_ca/_layouts/15/guestaccess.aspx?docid=1b2c88a7fa7b34931b38e0c8e2c9cf308&authkey=Aew3EQ4vmh8u9P0XLhi1dkQ

Matthew Jones October 17, 2016 at 10:53 PM

It looks like one of these was actually an issue of the selectItems array having a blank label on the constructor. (for the first error)

But I think at least MCMS and MCSC will be better after this.

Fixed

Details

Assignee

Reporter

Components

Fix versions

Affects versions

Priority

Created August 25, 2015 at 9:09 AM
Updated April 17, 2018 at 8:40 AM
Resolved May 23, 2017 at 10:22 AM