Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Regression: Timer not shown

Description

1. Publish a non-timed assessment.
2. Change the published assessment settings to be a 2 hours-timed assessment.
3. As student take the assessment: No timer is shown.

Activity

Show:

Raúl Sánchez Vegas July 27, 2016 at 4:36 AM

Verified in https://trunk-oracle.nightly.sakaiproject.org/portal/. It works well. Regards,

Raúl

Raúl Sánchez Vegas July 20, 2016 at 2:57 AM

Verified in http://sakai-trunk.atica.um.es/. It works well. Ready for PR. Regards,

Raúl

Alejandro González Jiménez July 13, 2016 at 10:05 AM
Edited

Ok, this was fixed for the Unpublished assessments in (see changes in SaveAssessmentSettings.java)

https://github.com/sakaiproject/sakai/commit/218a328cb8e17264bec6f979d32e692ac02161bd

so i guess i can do the same in SavePublishedSettingsListener

Alejandro González Jiménez July 13, 2016 at 9:51 AM
Edited

It seems that the issue was introduced by SAM-1408, this method

https://github.com/sakaiproject/sakai/blob/a1831ca528e6b78d2a0b0803afc95e0f2482685f/samigo/samigo-app/src/java/org/sakaiproject/tool/assessment/ui/listener/author/SavePublishedSettingsListener.java#L789

gets the old AssessmentMetaData from the Assessment instead of getting it from the AssessmentSettings. As a result of this we lose the changes in the hasTimeAssessment metadata (the one which tell us if the assessment has a time limit or not)

This could be easily fixed replacing this line

by

Still evaluating the side effects of this change and if the method can be refactored.

Matthew Jones July 5, 2016 at 10:15 AM

By default you can't edit published assessments

  1. When samigo.editPubAssessment.restricted is set to false, the published assessment is editable even if students have started taking it.

  2. DEFAULT: true

  3. samigo.editPubAssessment.restricted=false

Fixed

Details

Priority

Affects versions

Fix versions

Components

Assignee

Reporter

Labels

Created June 8, 2016 at 12:10 PM
Updated April 17, 2018 at 8:40 AM
Resolved July 26, 2016 at 5:04 AM