Crossmark not showed in incorrect answers when question's score is 0

Description

In SAM-973 an issue with not visible crossmarks was fixed. After applying it, I have found that they were not still visible in some of my questions.

The reason is a condition in deliverFillInTheBlank.jsp and deliverFillInNumeric.jsp that must be true to show crossmarks:

answer.answer.score gt 0

I don't know if there was a reason for this, but I think that it is a bug, so I have removed that check. If community agree that is not correct, I upload a patch for 2.9.x.

Attachments

3

Activity

Show:

Jasmine Thapa April 16, 2014 at 2:25 PM

Crossmark is showing in incorrect answers when question's score is 0.

test instance: sakai/trunk on Oracle - Built: 04/16/14 12:00 - Sakai Revision: 308248 (Kernel 11-SNAPSHOT) - Server sakai-nightly.uits.iupui.edu

Hui Tsao February 18, 2014 at 5:37 PM

Looks good to me too. Committed r306165.

Sam Ottenhoff February 13, 2014 at 10:13 AM

Logically, this patch makes sense to me. Karen or Lydia?

Juanjo Meroño December 17, 2013 at 6:27 AM

Daniel Merino December 9, 2013 at 2:48 AM

Attached two images, before my patch and after it.

Fixed

Details

Priority

Affects versions

Fix versions

Components

Assignee

Reporter

Created December 5, 2013 at 7:57 AM
Updated April 17, 2018 at 8:39 AM
Resolved February 18, 2014 at 5:37 PM