Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Clean up duplicate samigo timer events

Description

SAM-1947 added a new event TimedAssessmentRunnable.java
(now called sam.assessment.submit.timer.thrd) which is fired right after an event that was already there (sam.assessment.submit.thread)

It doesn't seem like we need two events here firing?

It's possible that after https://sakaiproject.atlassian.net/browse/SAM-3012#icft=SAM-3012 this might not even be firing correctly anymore? Need to try to test this one.

Activity

Matthew Jones March 30, 2018 at 9:31 AM

I added the fix, I don't think it's worth doing any conversion for this one as there will be duplicate in there already, so having two events named the same doesn't make sense. Not sure about deleting these old events either.

Matthew Jones March 30, 2018 at 9:25 AM

Yeah there's still two events posted here. It looks like the observer is still using the

EVENT_ASSESSMENT_SUBMITTED_TIMER_THREAD = "sam.assessment.submit.timer.thrd";

So this is probably the event to retain. So we'll just remove this sam.assessment.submit.thread.
 

EventTrackingService.post(EventTrackingService.newEvent(SamigoConstants.EVENT_ASSESSMENT_SUBMITTED_THREAD, "siteId=" + siteId + ", submissionId=" + ag.getAssessmentGradingId(), siteId, true, NotificationService.NOTI_REQUIRED)) . . . EventTrackingService.post(EventTrackingService.newEvent(SamigoConstants.EVENT_ASSESSMENT_SUBMITTED_TIMER_THREAD, notiValues.toString(), siteId, true, SamigoConstants.NOTI_EVENT_ASSESSMENT_TIMED_SUBMITTED));

 

Benjamin Rappleyea March 30, 2018 at 8:36 AM

seconding Sam's inquiry here, is this still an issue or should this JIRA be closed out?

Sam Ottenhoff September 7, 2017 at 4:14 PM

Is this still an issue?

Fixed

Details

Priority

Affects versions

Fix versions

Components

Assignee

Reporter

Labels

Created July 14, 2017 at 3:57 PM
Updated October 10, 2018 at 3:34 PM
Resolved April 3, 2018 at 11:20 AM

Flag notifications