Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Timer thread submission events can be logged incorrectly

Description

Some sam.assessment.thread_submit events get logged with an anon session-id, e.g.

vula8a?

and others get logged with a sessionid that implies a userid:

~vula8a~444fbb74-3727-4a01-84d8-05546954646b

However that userid may not be the user associated with the assessment for which the event is being posted.

Code in

samigo-app/src/java/org/sakaiproject/tool/assessment/ui/queue/delivery/SubmitTimedAssessmentThread.java

Attachments

1
  • 18 Nov 2015, 05:03 AM

Activity

Show:

Matthew Jones June 16, 2017 at 4:51 PM
Edited

I'm still seeing this issue both #2 and #3 testing on SAM-3224, looks like it was related also to SAM-2788. Looking into this.

Stephen Marquard December 10, 2015 at 6:59 AM

This change is now in production at UCT and is working as expected.

Stephen Marquard November 18, 2015 at 5:05 AM

The attached patch addresses 4 issues:

1. A timer submission log entry is not logged in the T&Q event log (because it isn't saved). The save call is added here.

2. The event log can be logged with a misleading userid because the session user may be set by a previous thread submission if the assessment includes updating the Gradebook.

3. siteId=null replaced with the correct siteId (for consistency with other events which include the siteId).

4. Adds INFO logging when an auto submission takes place.

Fixed

Details

Priority

Affects versions

Fix versions

Components

Assignee

Reporter

Labels

Created November 17, 2015 at 7:59 AM
Updated April 17, 2018 at 8:26 AM
Resolved December 2, 2015 at 12:14 PM

Flag notifications