Evaluation tool comes from contrib and it's not available in the QA servers. I tested it in my local in "demo" mode with a profiling tool.

Someone with evaluation tool in a real environment can confirm the performance upgrade?

This looks hard to test. How can we get it verified? Is it being used somewhere production?

The proposed pull requests try to upgrade the performance for the method HierarchyRenderUtil::renderHierarchyNode.

This is the calls tree for that method:

• (external)getChildNodes

  • (provider)getChildNodes

    • (hierarchy)getChildNodes ---> cache

• (external)getEvalGroupsForNodes

  • (provider)getEvalGroupsForNodes

    • (provider)getEvalGroupNodesByNodeId

      • (hierarchy)getChildNodes

      • (hierarchy)getNodesByIds

  • (external)getEvalGroupsForNodeSectionAware

    • (external)getEvalGroupNodeByNodeId

      • (external)getEvalGroupNodesByNodeId

    • (external)getRulesByNodeID

      • (external)checkNodeExists

        • (external)getNodeById ---> cache

          • (provider)getNodeById

            • (hierarchy)getNodeById ---> cache

As you can see, we have added a cache system at two levels :

• In the ExternalHierarchyLogicImpl (inside evaluation)

• In the HierarchyServiceImpl (inside hierarchy)

Here, an image with the difference between three files:

• nocache.txt : Original system

• cache.txt : Cache implemented in both levels (evaluation and hierarchy)

• halfcache.txt : Cache implemented only in hierarchy

As you can see, we have reduced the calls to "getNodeMeta" from 1812 to 284.

These three files are also included:

We have noticed that the hierarchy loading is so long because, every time somebody clicks on expand/collapse, the entire tree is refreshed. What if we only update the affected element by ajax (I don't know if this is possible with RSF)?

What do you think?