Support for roster/section based delivery
Description
Attachments
- 26 May 2016, 01:36 PM
- 26 May 2016, 01:36 PM
- 26 May 2016, 01:36 PM
- 26 May 2016, 01:36 PM
- 26 May 2016, 01:36 PM
- 26 May 2016, 01:36 PM
- 26 May 2016, 01:36 PM
- 26 May 2016, 01:36 PM
- 26 May 2016, 01:36 PM
- 26 May 2016, 01:36 PM
is depended on by
is related to
Activity
Matthew Jones June 21, 2017 at 4:19 PM
We have a report here of someone taking the assessment VIA URL and notifying the user that something has gone wrong. The stack trace is below and looks to be related to the code in this ticket. It might have been given out as an anonymous evaluation and then it makes sense this code wouldn't work? I'll file a new ticket.
19-Jun-2017 13:56:19.468 INFO [http-nio-9202-exec-4] org.sakaiproject.evaluation.logic.EvalDeliveryServiceImpl.saveResponse Locking evaluation (61) and associated entities
19-Jun-2017 13:56:19.487 INFO [http-nio-9202-exec-4] org.sakaiproject.evaluation.logic.EvalDeliveryServiceImpl.saveResponse User (Anon_User_de5dd973-c8cd-4b9c-ada1-e7e5dd6dd5f1) saved respon
se (123) toevaluation (61) for groupId (/site/c796f76e-c7b5-4d7e-811e-3a45e4fa5662) with 24 answers, response is complete
19-Jun-2017 13:56:19.690 WARN [http-nio-9202-exec-7] org.sakaiproject.entitybroker.util.devhelper.AbstractDeveloperHelperService.getUserHomeLocationReference Cannot get the userhome location
Reference because there is no current user: null
19-Jun-2017 13:56:19.696 WARN [http-nio-9202-exec-7] PonderUtilCore.handleLevel1Error Exception rendering view:
java.lang.IllegalArgumentException: Could not get location from userReference (null) to generate URL
at org.sakaiproject.entitybroker.util.devhelper.AbstractDeveloperHelperService.getUserHomeLocationURL(AbstractDeveloperHelperService.java:300)
at org.sakaiproject.evaluation.tool.renderers.NavBarRenderer.makeNavBar(NavBarRenderer.java:110)
at org.sakaiproject.evaluation.tool.producers.SummaryProducer.fill(SummaryProducer.java:114)
at org.sakaiproject.evaluation.tool.producers.EvalCommonProducer.fillComponents(EvalCommonProducer.java:53)Brian J. December 19, 2016 at 9:55 AM
I hear ya! The buttons are great in their intentions... they just need to work properly 
Matthew Jones December 19, 2016 at 9:53 AM
@Brian J. Yeah I don't get them either, I just saw it as an already filed issue because I kept running into this problem, wanting to hit this button when I was testing out some new features last week. 
Brian J. December 19, 2016 at 8:49 AM
Thanks @Matthew Jones; I guess I don't get notifications when new EVALSYS tickets are created, otherwise I would have picked this up a little earlier. Regardless, I'll take a look.
Matthew Jones December 17, 2016 at 6:36 PMEdited
The buttons introduced here are causing a problem in Sakai on trunk nightly. When you click then it looks to be resulting in infinite embedded windows. This is reported in EVALSYS-1484. This seems like it either should be fixed somehow or have a way to be disabled.
I think if maybe "_target=parent" was in the anchor it woudl work but I'm not sure how to do that with RSF UILink. Maybe just doing a client side fixup of something like
$("a").attr("target","_parent");Though you wouldn't want it to happen for every link, so we'd still have to put it in some other identifiable container maybe? Maybe just have a way to disable these is still easiest.
Would work?
Details
Assignee
Brian J.Brian J.Reporter
Brian J.Brian J.Conversion Script Required
YesProperty addition/change required
YesFix versions
Affects versions
Priority
Major
Details
Details
Assignee
Reporter
Conversion Script Required
Property addition/change required
Fix versions
Affects versions
Priority
Major
This ticket encapsulates all work done by Western University to support roster/section based delivery. It includes the following items (screenshots attached below for some of the various features):
Evaluations can now be assigned to individual sections/rosters or sites (the default is still site based)
This is controlled by a checkbox on the settings page for an evaluation
Section based evaluations resolve to a user's section role, rather than site role
Only students, instructors and assistants from the selected sections are picked up (rather than their parent sites). In effect, students only evaluate instructors of the section they belong to, rather than all instructors in the parent site
A new report format is available for XLS, CSV and PDF exported results, for both section and site based evaluations
There is now a checkbox in the reporting interface to control which format the exports obey
Several issues with the CSV export have been fixed:
Force I.E. to download the file instead of displaying it in the frame (as a blank grey screen)
Added headers to the CSV export
Sometimes, the file had no file extension or had a .pdf file extension
The title of the file was sometimes truncated
Implemented default sorting for XLS and CSV reports
The concept of hierarchy node 'rules' has been introduced
Administrate (create, delete, update) hierarchy node rules via the 'Administrate Hierarchy' interface
'Rules' are text based criteria used to filter the list of available sites/sections a user can release evaluations to
You can assign any number of rules to any node in the Hierarchy
Rules can be applied to either section or site titles, and use the following qualifiers:
Section or site title starts with, ends with, contains or is a given string
Once you've granted the "Assign Evaluation" permission to a user for a given hierarchy node, when they go to release an evaluation they will only be presented with a list of sites or sections that meet the "rules" for their hierarchy node
Administrate Hierarchy UI changes:
A new column has been introduced in the hierarchy table for "Assigned Rules"
In the "Modify Node Permissions" UI, the 'new' form row has been moved to the top of the table for accessibility reasons
The "Select Groups" UI has been modified to include some new buttons for ease of use: Select All, Select None and Cancel
When taking an evaluation, you are taken away from the main Sakai "frame". On submission of the evaluation, you are returned to the Eval Dashboard, but there is no obvious way to either get back to the main Sakai context or log out. As such, "Logout of {ui.service}" and "Return to My Workspace" links have been added to the navBar to address this issue
Previous to this PR, you're not warned until the very last screen that "You may adjust the groups assigned to this evaluation up to the start date of the evaluation (<closeDate>)."
This message is wrong, and displayed in the wrong interface
It is now displayed to the user earlier, beside the link to modify assigned groups for the evaluation, and the wording has been updated to be more accurate:
"You may add more assigned groups to the evaluation at any time, however you can only remove assigned groups up to the start date of the evaluation ({0})."
This PR also contains a fix for the Expert Item Groups interface not working properly (JavaScript issue).
The following sakai.properties have been introduced (defaults preserve original functionality):
evalsys.report.new.style.default=true/false (default is false)
evalsys.section.aware.default=true/false (default is false)
evalsys.results.sharing.default=owner/private/visible/shared/public (default is visible)
evalsys.instructor.view.responses.default=true/false (default is true)
Conversion scripts to migrate from EvalSys 1.4 to 11 have been introduced for Oracle and MySQL:
sakai-evaluation-impl/src/ddl/conversion/mysql/eval-1.4_to_eval-11.sql
sakai-evaluation-impl/src/ddl/conversion/oracle/eval-1.4_to_eval-11.sql
The auto.ddl scripts have been updated:
sakai-evaluation-impl/src/ddl/db2/evaluation.sql
sakai-evaluation-impl/src/ddl/derby/evaluation.sql
sakai-evaluation-impl/src/ddl/hsqldb/evaluation.sql
sakai-evaluation-impl/src/ddl/mssql/evaluation.sql
sakai-evaluation-impl/src/ddl/mysql/evaluation.sql
sakai-evaluation-impl/src/ddl/oracle/evaluation.sql
sakai-evaluation-impl/src/ddl/postgres/evaluation.sql