Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Add utility methods to EmailTemplateService

Description

Code using the EmailTemplateService tends to re-implement the methods loadTemplate() and xmlToTemplate() over and over. This patch will add them to the service itself.

Activity

Show:

Neal Caidin August 25, 2016 at 7:24 AM

Based on comments, setting to verified.

Paul Lukasewych August 25, 2016 at 7:19 AM

I have between 50 and 60 in my recently created 11.x database, so it sounds about right.

Neal Caidin August 24, 2016 at 9:01 PM

I ran a local copy and deleted my database before spinning up. It looks like the email templates were created. Logged in as admin/admin and go to email templates and see a long list, around 50-ish or something? Does that sound like the right number?

Paul Lukasewych August 24, 2016 at 2:34 PM

These methods are called on startup to transform the XML templates stored in code into email templates in the database. To test, you'd have to spin up a new instance of Sakai and make sure all the email templates are created.

Neal Caidin August 24, 2016 at 2:18 PM

What is the Test Plan for this Jira? A code review? Or QA testing of the EmailTemplateService?

Fixed

Details

Priority

Affects versions

Fix versions

Components

Assignee

Reporter

Labels

Created June 17, 2016 at 7:40 AM
Updated March 23, 2022 at 3:02 PM
Resolved June 17, 2016 at 8:35 AM

Flag notifications