Tool Order Access Options Vary With Tools

Description

Some tools in the Tool Order list have the fourth option of "lock access to this tool", such as the Calendar, Announcements and Resources tools. However, many don't (for example, Tests & Quizzes and Assignments don't).

Shouldn't they all offer this option?

Resources has this option: https://www.evernote.com/shard/s699/sh/7def2195-7584-432d-9ca3-cc632b5847a5/fc4ca14a38cf9a08aa46d74a924ab6f9

Assignments does not have http://www.evernote.com/shard/s699/sh/4cdf8663-24ce-4e6d-8926-d3c0be5d4bc6/f8e5a245c9864edf03d9f8b58b11e58b

Attachments

2

Activity

Matthew Jones March 27, 2018 at 9:39 AM

This issue is a duplicate of which is not yet resolved.

Austin January 9, 2018 at 1:11 PM

I suspect we're running into this issue after a recent upgrade from 10.7 to 11.4. I'm not totally sure, but if a tool (e.g. Discussions and Private Messages (jforum) was 'locked' in 10.7 after we upgraded to 11.4, the lock/unlock icon is no longer displayed, so it can't be unlocked.

Laura Cira December 6, 2017 at 1:24 PM

Opening this issue. It's been stagnant for over a year without resolution, and still seems to be an issue in https://qa2-us.nightly.sakaiproject.org

Kyle Blythe May 2, 2016 at 12:47 PM

We have noticed this in relation to the tool order screen in 11, and do not believe this was an issue in 10.x.

Current screenshot in 11:

10.x maintenance branch:

It looks like the code was introduced for 11.x and doesn’t seem to take into account that some tools don’t set the `functions.require` configuration. For example, for the Resource tool:

https://github.com/sakaiproject/sakai/blob/master/content/content-tool/tool/src/webapp/tools/sakai.resources.xml#L22

However, the Assignment tool doesn’t have a similar entry:

https://github.com/sakaiproject/sakai/blob/master/assignment/assignment-tool/tool/src/webapp/tools/sakai.assignment.grades.xml

The problem code is here https://github.com/sakaiproject/sakai/blob/master/site-manage/pageorder/tool/src/java/org/sakaiproject/site/tool/helper/order/impl/SitePageEditHandler.java#L469:

public boolean allowDisable(SitePage page) {

if (!(serverConfigurationService.getBoolean(DISABLE_ENABLED_CFG, true))) {
return false;
}
List<String> permissions = getRequiredPermissions(page);
return !(permissions.isEmpty() || permissions.contains(SITE_UPD) || permissions.contains(SITE_VISIT));
}

Basically, all those checks in the final line need to be false. So the permissions can’t be empty and permissions shouldn’t contain SITE_UPD or SITE_VISIT.

Neal Caidin April 27, 2016 at 3:03 PM

Seems like a feature request. I believe this is the behavior in Sakai 10?

Duplicate

Details

Priority

Affects versions

Components

Assignee

Reporter

Environment

Win 7, IE 11

Created April 13, 2016 at 10:38 AM
Updated March 27, 2018 at 9:39 AM
Resolved March 27, 2018 at 9:39 AM