Can't edit syllabus items (JS error)

Description

When trying to click the edit button in syllabus there's a javascript error on nightly (2015-10-05) This prevents editing of any syllabus items.

Uncaught TypeError: this.tip(...).find is not a function$.extend.innerShow @ jqueryui-editable.js:4564Popup.show @ jqueryui-editable.js:1073Editable.show @ jqueryui-editable.js:1786Editable.toggle @ jqueryui-editable.js:1808(anonymous function) @ jqueryui-editable.js:1530m.extend.proxy.m.isFunction.e @ jquery-1.11.3.min.js?version=:2m.event.dispatch @ jquery-1.11.3.min.js?version=:4m.event.add.r.handle @ jquery-1.11.3.min.js?version=:4 syllabus.js:281 Uncaught TypeError: Cannot read property 'left' of undefined

Activity

Show:

Derek Ramsey March 3, 2016 at 9:24 AM

Tested on http://qa01-sakai.marist.edu:8080/portal/

Instructor can successfully edit syllabus items.

Matthew Jones October 22, 2015 at 1:26 PM

I submitted a PR with the version of jqueryui-editable.js that is on that other PR. Looks like it fixes this problem.

This was pulled "as-is" from vitalets/x-editable#724. Probably includes a lot of updates. Seems to fix the problem.

The alternative was to use a different library (that didn't have the jqueryui dependency). But that would require also changing the event listeners and using poshytip is we stuck with this library, which doesn't look as good, or choosing a different library which would be more work.

Matthew Jones October 21, 2015 at 5:03 PM

Yeah, I'm seeing that too. Looks like we'll have to build a version from source if we want, but maybe dropping the ui dependency and going with the regular jquery version of this plugin would be enough.

The PR https://github.com/vitalets/x-editable/pull/724 says that it's not even compatible with 1.11.4 and it's not even merged.

Neelam Bhandari October 20, 2015 at 8:46 AM

this error is because of the jquery-ui -version. it works all right with the jquery-ui.1.10.3.full.min.js but fails with jquery-ui.1.11.3.min.js.
looks like fix is not merged in the version-11+ releases: https://github.com/vitalets/x-editable/issues/687

Fixed

Details

Priority

Affects versions

Fix versions

Components

Assignee

Reporter

Created October 5, 2015 at 10:40 AM
Updated March 3, 2016 at 9:24 AM
Resolved October 22, 2015 at 5:59 PM

Flag notifications