The support.email property isn't defined in sakai.properties files, change to mail.support

Description

In the default.sakai.properties file:

# Sets the 'from' email address and name for password reset emails (if not set, falls back to mail.support) # accountValidator.checkValidations.fromEmailAddress= # accountValidator.checkValidations.fromEmailName=

And you can find the mail.support property:

# Email support address used in incoming email rejection messages. # DEFAULT: none (null) # mail.support=

The reset password tool uses support.email property.
If support.email isn't defined, then the e-mail notification doesn't work. This property doesn't appear in any sakai.properties files.

Are both the same property? In that case, Reset Pass Tool should use mail.support instead of support.email.
Or, are they differents? In that case, the properties file should define support.email with an explanation of usage.

Activity

Juan Arcadio Martinez Carceles April 11, 2016 at 8:13 AM

Tested on trunk.

Neal Caidin April 7, 2016 at 11:03 AM

Thanks. I added to the Test Plan field. Most functional QA testers won't be able to follow , but maybe we can get someone a bit more technical to run through.

Brian Baillargeon April 7, 2016 at 10:42 AM
Edited

  • Ensure you do not have support.email set in sakai.properties

  • use reset-pass with siteManage.validateNewUsers=false in sakai.properties

  • use reset-pass with siteManage.validateNewUsers=true in sakai.properties

    • before responding to the email, use reset-pass a second time

  • with siteManage.validateNewUsers=true in sakai.properties

    • configure a "New Account" tool instance with a tool property: "validate-through-email", and test it

    • add an unofficial participant to the site (who isn't already in the system)

Verify you don't get any bug reports and that your mail.support address is used as appropriate

I think that should be a pretty thorough test of all email functionality in reset-pass / account-validator. There's also a "accountValidator.sendLegacyLinks" property, for some old behavior (sends 'reset-pass' users, 'add participants' users, as well as 'new account' users to the same RSF page; it was getting to be impossible to support, so I split everything up at some point in Sakai 2.9, and I strongly recommend discontinuing support for that property).

Neal Caidin April 7, 2016 at 9:40 AM

How to verify this Jira so it gets merged into 11?

Matthew Jones March 28, 2016 at 11:49 AM

Yea, if you're confident they would, then just replace it!

Fixed

Details

Priority

Affects versions

Fix versions

Assignee

Reporter

Labels

Property addition/change required

Yes

Created September 29, 2015 at 10:33 AM
Updated August 2, 2016 at 7:51 AM
Resolved April 6, 2016 at 11:05 AM

Flag notifications