Empty FROM header in reset password email
Description
Attachments
is related to
Activity
Former user September 10, 2014 at 9:08 AM
This problem is still in trunk.
We missed the property "support.email" in our sakai.properties and Hotmail (for instance) did not accept the password reset email with an empty "from"-address.
Seth Theriault March 8, 2013 at 6:44 AMEdited
Why doesn't reset-pass have a default from setting if support.email doesn't exist? I see:
emailTemplateService.sendRenderedMessages(templateKey , userReferences, replacementValues,
serverConfigurationService.getString("support.email"), serverConfigurationService.getString("support.email"));
(account-validator-impl/src/java/org/sakaiproject/accountvalidator/logic/impl/ValidationLogicImpl.java:399)
We have plenty of instances where no-replay@sakaiservicename is inserted for things like this.
Neal Caidin March 8, 2013 at 6:44 AM
I tested on the experimental server with the support.email and it works. I think we just need to add the support.email property to the default.sakai.properties , with a short description of what it does and commented out. Does it affect areas of Sakai other than just the password reset? I would imagine so.
Jean-François Lévêque March 8, 2013 at 5:25 AM
Maybe there should be a warning in reset password's UI about configuration lacking that might lead to issues with reset password emails.
David Horwitz March 8, 2013 at 1:29 AM
From the email template service I'm not sure what can be done here except suppress the header entirely if there is no valid from:
if (StringUtils.isNotBlank(rt.getFrom())) {
headers.add("From: \"" + rt.getFrom() );
} else {
headers.add("From: \"" + fromName + "\" <" + fromEmail + ">" );
}
Details
Priority
MajorAffects versions
Components
Assignee
Core TeamCore TeamReporter
Neal CaidinNeal CaidinEnvironment
Mac OS X - Mountain Lion - 10.8.1, Gmail and Apple mail program
Details
Details
Priority
MajorAffects versions
Components
Assignee
Core TeamReporter
Neal Caidin
When testing issue , I noticed some strangeness in the From header, though Gmail handled better than Apple Mail. Below is the header information and enclosed are a couple of screenshots.
-------------
Delivered-To: nealcaidin@sakaifoundation.org
Received: by 10.64.176.197 with SMTP id ck5csp60638iec;
Thu, 30 Aug 2012 18:21:09 -0700 (PDT)
Received: by 10.224.17.145 with SMTP id s17mr14713509qaa.99.1346376068511;
Thu, 30 Aug 2012 18:21:08 -0700 (PDT)
Return-Path: <postmaster@sakai-nightly.uits.iupui.edu>
Received: from sakai-nightly.uits.iupui.edu (sakai-nightly.uits.iupui.edu. [134.68.26.90])
by mx.google.com with ESMTPS id w19si1684635qct.111.2012.08.30.18.21.07
(version=TLSv1/SSLv3 cipher=OTHER);
Thu, 30 Aug 2012 18:21:08 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of postmaster@sakai-nightly.uits.iupui.edu designates 134.68.26.90 as permitted sender) client-ip=134.68.26.90;
Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of postmaster@sakai-nightly.uits.iupui.edu designates 134.68.26.90 as permitted sender) smtp.mail=postmaster@sakai-nightly.uits.iupui.edu
Received: from sakai-nightly.uits.iupui.edu (localhost.localdomain [127.0.0.1])
by sakai-nightly.uits.iupui.edu (8.13.8/8.13.8) with ESMTP id q7V1LaE9013928
for <nealcaidin@sakaifoundation.org>; Thu, 30 Aug 2012 21:21:36 -0400
Date: Thu, 30 Aug 2012 21:21:35 -0400 (EDT)
Message-ID: <1998479811.1.1346376096022.JavaMail.tomcat-nightly@sakai-nightly.uits.iupui.edu>
Subject: New Password Request
MIME-Version: 1.0
Content-Type: multipart/alternative;
boundary="----=_Part_0_833948352.1346376095822"
From: "" <>
To: "Neal Caidin" <nealcaidin@sakaifoundation.org>
Precedence: bulk
------=_Part_0_833948352.1346376095822
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 7bit