Fix the in-situ Edit screen of BasicLTI tool
Description
relates to
Activity
John Johnston May 18, 2013 at 8:11 PM
I noticed that if I actually update the values for Tool Title (Above the tool), Button Text (Text in tool menu), or Frame Height, the values are saved, but the changes are not reflected in the UI.
Test case:
1. Log in to Admin Workspace
2. In External Tools select the Tools Available in System tab
3. Select the edit link to the right of a configured tool
4. Select the Allow radio button for "Allow tool title to be changed", "Allow button text to be changed", and "Allow frame height to be changed"
5. Save changes
6. Add the LTI tool you just edited to a site and keep the default settings
7. Launch the tool
8. Click the config icon in the upper right
9. Change the Tool Tittle, Button text, and Frame Height
10. Click Update Options button
11. Notice the settings are saved but the UI does not change
Note: The other user in-situ definable options such as Launch URL, Secret, Key, etc, seem to work properly
Hudson CI Server May 3, 2013 at 1:04 PM
Integrated in basiclti 2.1.x #4 (See http://builds.sakaiproject.org:8080/job/basiclti%202.1.x/4/)
https://sakaiproject.atlassian.net/browse/BLTI-209#icft=BLTI-209 merge trunk r123326 (Revision 123591)
Result = SUCCESS
Anthony Whyte May 3, 2013 at 12:17 PM
Merged 2.1.x r123591.
Anthony Whyte May 3, 2013 at 12:13 PM
Don't forget to set the 2.1.x status to merge.
Beth Kirschner April 30, 2013 at 1:42 PM
Verified with following test plan:
1. go to the Admin workspace External Tools, and add new LTI tool if necessary;
2. add the basicLTI tool to a site;
3. go to the site, launch the basicLTI tool. And click on the Edit button on the top right corner of the tool panel itself, and verify that the attributes shown in the edit screen is compatible with the the tool definition, i.e. if the "allow" is set for an attribute, the attribute input field should show up in this Edit screen.
There is one Edit button to the right upper corner of BasicLTI tool, where user can edit the LTI tool settings.
However, the page is constructed with hard-coded attributes names, instead of using the tool_model, content_model defined in API, and use Foorm.java to automatically generated HTML input fields.