Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

myworkspace.info.url not internationalized

Description

In several web pages were internationalized, including the page set in property myworkspace.info.url. We have this working fine in our 2.7.1 production environment.

Now we are testing 2.9.2 and this i18n is not working. This page is always the same that is set in sakai.properties property.

In 2.9.x QA is happening too. I don' know if this can be a regression of 2.9 or maybe from 2.8.

Attachments

1

Activity

Anthony Whyte July 17, 2013 at 10:21 AM

Merged 2.9.x r127107.

Jean-François Lévêque July 12, 2013 at 4:57 AM

Changing the language in the preferences now updates the My Workspace Information Display
when a translation is available. I've tried with Spanish.

Aaron Zeckoski July 11, 2013 at 11:39 AM

Ready for QA to verify

Daniel Merino June 27, 2013 at 3:59 AM

Thanks for pointing me to the code, Yuki.

Taking a look, it seems that the change from servlet to portlet has invalidated some code and fixing it has been left for later (there is a TODO included)

I have made a little patch that fixes this. I have tested it and seems to work fine.

I upload the patch for 2.9.2, probably it will be valid also for trunk.

Yuki Yamada June 26, 2013 at 5:06 PM

It was introduced via SAK-12563.

Until 2.9.1, i18n had been controled by getLocalizedURL method in the following source code:
https://source.sakaiproject.org/svn/web/tags/sakai-2.9.1/web-tool/tool/src/java/org/sakaiproject/web/tool/IFrameAction.java

But in 2.9.2, 'sakai.iframe.myworkspace' tool was moved to web-portlet from web-tool, and getLocalizedURL was commented out:
https://source.sakaiproject.org/svn/web/tags/sakai-2.9.2/web-portlet/src/java/org/sakaiproject/portlets/PortletIFrame.java

However, I can not find out what was the issue which should be commented out.

Fixed

Details

Priority

Affects versions

Fix versions

Components

Assignee

Reporter

Labels

Created June 21, 2013 at 6:01 AM
Updated March 13, 2015 at 12:33 PM
Resolved July 11, 2013 at 11:39 AM