Target is being reset to (_blank) after Post / Save for <not set> and <popup window>
Description
Attachments
- 09 May 2013, 07:08 AM
- 09 May 2013, 07:08 AM
duplicates
relates to
Activity
Noah Botimer November 23, 2015 at 3:36 PM
I'm closing this based on Matthew's comments. If someone is having problems with this in a way that configuration does not fix, please reopen.
Matthew Jones January 9, 2014 at 5:20 PMEdited
The option for <popup window> no longer exists in the current version of CKEditor.
introduces a sakai property
content.cleaner.add.blank.target
That looks like when set to false will no longer add a target if it doesn't exist, otherwise it's going to add the blank. This seems like a configuration issue at this point?
Noah Botimer August 19, 2013 at 8:22 AM
Thanks, Aaron. I know the processing has oscillated multiple times (setting, clearing, leaving). I wonder if there is a clear decision documented somewhere. In any case, I will review the patch and apply if it looks good and reflects the current behavior of trunk.
Aaron Zeckoski August 16, 2013 at 12:59 PM
This is not related to antisamy. When we are using Antisamy, we still use the links processor from the legacy code in order to be backwards compatible with the previous behavior. That is what is doing this. It happens before antisamy processing occurs.
Noah Botimer August 16, 2013 at 10:17 AM
Aaron, could you please verify that this is linked to the appropriate AntiSamy tickets and assign appropriately?
I picked up an issue with two of the link targets in all the tools listed in the test script, with the exception of 'Resources - HTML page' which works as expected.
The target is being reset to (_blank) after Post / Save for <not set> and <popup window> - so CK Editor looks like it has saved your selection after clicking OK, but when you save and then Edit again, the target has changed:
<not set> resets to (_blank)
<popup window> resets to (_blank)
Steps to reproduce:
1. Create an Assignment
2. In Assignment Instructions, click Link button
3. Choose Link Type 'URL'
4. Enter URL e.g. www.google.co.za/
5. Click Target tab
6. Leave default target as <not set>
7. Click OK
8. Right-click on the link, you just created, choose Edit Link, and verify your settings are still there, and you can also check that the HTML source looks something like e.g:
<p>
<a href="http://www.google.co.za/">http://www.google.co.za/</a>_this_is_the_not_set_example</p>
9. Click Post
10. In the Assignment list, again edit the same assignment
11. Click the Source button and check the HTML source after the save which shows that the the target has since changed to _blank: e.g.
<p>
<a href="http://www.google.co.za/" target="_blank">http://www.google.co.za/</a>_this_is_the_not_set_example</p>
<p>
12. You can also do this by right-clicking the URL and going into the Target tab
Follow the same steps for the <popup window> target...
Should look like this after Post:
<a href="http://www.google.co.za/" onclick="window.open(this.href, '', 'resizable=no,status=no,location=no,toolbar=no,menubar=no,fullscreen=no,scrollbars=no,dependent=no'); return false;">http://www.google.co.za/</a>_this_is_the_popup_window_example</p>
However it looks like this after Post:
<a href="http://www.google.co.za/" target="_blank">http://www.google.co.za/</a>_this_is_the_popup_window_example</p>