Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Skin confusion: hardcoded skins, misuse of properties, confusing portal settings

Description

In 2.9, the previously straightforward skin.default property became confusing and unintuitive because of the bug in SAK-23395. Investigation as to why things seemed to work so inconsistently SAK-23396 led to the discovery of the fact that nearly every tool was doing something skin-related incorrectly. I've created JIRAs for the most problematic aspects, but not for everything, linked below. The community should consider either revamping the way skinning works, providing clearer documentation on the appropriate ways to use skins, or performing more static analysis on newly introduced core code such as lessonbuilder which wins for most files with hardcoded references to the "default" (but no longer default) skin.

Attachments

1

is related to

relates to

Activity

Show:

Charles R Severance June 25, 2015 at 12:06 AM

This is some combination of fixed and won't fix. It is no longer an issue with Sakai 11 as the entire skin structure has been changed. And for Sakai 10 - now that we are at 10.5 - we will not be doing non-upwrds compatible improvements to skin conventions in 10.x.

Juanjo Meroño November 28, 2014 at 4:54 AM

I've added a file with the results of a grep command looking for /skin/default/ references in trunk at rev.315736.
Is still present in: citations, config, emailtemplateservice, gradebook, help, lessonbuilder, mailsender, osp, podcasts, polls, portal, reference, reset-pass, samigo, search, site and site-manage.

Neal Caidin April 3, 2013 at 1:19 PM

Assigned this to you David A., since you seem to be leading the charge on this issue.

Thanks!

David Horwitz March 31, 2013 at 4:01 AM

I think that the tool.css issue is a misunderstanding of how RSF works.

<link href="/library/skin/default/tool.css" type="text/css" rel="stylesheet" media="all" rsf:id="scr=portal-matter" />

In the source will be rendered to the correct tool.css:

<link href="/library/skin/neo-default/tool.css" type="text/css" rel="stylesheet" media="all" />

the rsf:id="portal-matter" being the magic glue. If there is a case where the substitution is not happening please jira that.

Neal Caidin March 28, 2013 at 7:16 AM

Looks like this one is actively being worked on. Who is overseeing the effort to keep it moving? Would like to have an "assignee" for this one.

Won't Fix

Details

Priority

Affects versions

Components

Assignee

Reporter

Labels

Created March 22, 2013 at 8:41 AM
Updated June 25, 2015 at 12:06 AM
Resolved June 25, 2015 at 12:06 AM