Large number of inserts from completeGet->refreshAuthzGroup
Description
Attachments
is related to
Activity
Neal Caidin June 28, 2014 at 11:28 AM
Anyone watching this ticket probably is interested in KNL-1273.
Hudson CI Server June 20, 2014 at 6:28 PM
Integrated in sakai-trunk-java-1.7 #291 (See http://builds.sakaiproject.org:8080/job/sakai-trunk-java-1.7/291/)
reverse merge of r309889 (Revision 310332)
Result = SUCCESS
Hudson CI Server June 20, 2014 at 4:23 PM
Integrated in sakai-10-java-1.7 #88 (See http://builds.sakaiproject.org:8080/job/sakai-10-java-1.7/88/)
merge 310332 to 10.x (Revision 310334)
Result = SUCCESS
Sam Ottenhoff June 20, 2014 at 10:59 AM
Per discussion in I have reverse merged r309889 from trunk with r310332.
Branch manager: please merge r310332 into 10.x branch.
No further work after the 10.x merge should happen in this JIRA.
Paul Lukasewych June 19, 2014 at 3:38 PMEdited
Am I correct to assume that if we have a realm with no provider, yet it has users with status provided = true, Sakai is supposed treat this as the provider was removed and remove all the provided users from the realm? Or should it be flipping those users to not be provided anymore, but keep them in the realm?
Relates to KNL-800, introduced by change in KNL-1183.
There seems to be a major performance regression now around this and KNL-800 in Sakai 10. I'd consider it a blocker.
In the past, the only place I was seeing refreshAuthzGroup actually called was on a save. It's in completeGet but by
if (updateProvider) which always seems to be false.
This code if the cache for that realm is null, it calls refreshAuthzGroup.
Because of some changes in KNL-800 every path through that causes inserts on the SAKAI_REALM_RL_GR for every user.
DEBUG - DbAuthzGroupService - refreshAuthzGroup(): deleted: 0 inserted: 21 provided: 21 nonProvider: 0
This basically all leads to a ton of new inserts, especially before this cache is established. It feels like the bug is more around how KNL-800 is working rather than this code, it's just this revealed the problem.