from yesterday's data, Thomas says its a pass.
so........

QA RESULTS -
pass

rSmart dev server
SmartSite@UCDavis - 2.6.4.0 - Sakai 2.6.2 - Server "ucddev1"

TESTING PROCESS -
site AAA 123 123 su10 is letter grade
nobody has grades for anything
1 - exported xls version of gb, deleted all but 1 item (deleted it's comments column) 10 point item
2 - grade that as combination of letter (real people a-f) and % (sakaistus - 95, 85, 75, 65, 55) grades
3 - add new item new from xls [25 points] and graded w/combination as 90-60, a- to f
4 - imported
5 - preview shows real people as lower case, sakaistus as uppercase highlighted in blue
6 - grades came in, numbers converted to letters
7 - w/only 2 graded items, course grade reflected as ( - ) in all cases, I assume because new item
has greater weight than old one?

grading results...
[point value] columns are how score was entered in spreadsheet
next 2 columns are the grade as displayed after import
C.G. is the resultant course grade
Student Name [10] [25] 10 25 C.G.
Djajapranata, Paulus b b- B B- B-
Five, Sakai Student 55 50 F F F
Four, Sakai Student 65 60 D D- D-
Mccarthy, Christopher d d- D D- D-
Mudryj, Maria c c- C C- C-
One, Sakai Student 95 90 A A A
Peterson, Peter f f F F F
Three, Sakai Student 75 70 C C- C-
Two, Sakai Student 85 80 B B- B-
Watson, Johanna a a- A A- A-

emailed Thomas as to if this test is correct, if it's a pass or more testing is needed.

bizarre...the table above is nicely formatted in "edit" mode so it's readable, but when I save it all
gets mashed together. sorry about that.

r69351

First fix I tried was to refactor getDisplayGrade to use convertPercentageToLetterGrade instead of the user entered grading scale. This didn't seem to work.

The problem is that the method convertPercentageToLetterGrade in GradeCalculationsOOImpl has a non evenly distributed grading scale. I replaced that with an evenly distributed scale and it worked fine.

Test case:

5 Assignments:
A1 = C
A2 = C
A3 = C-
A4 = C-
A5 = C-
End Grade = C-

Next I checked the exact boundary case of 6 assignments, 3 grades being a C and 3 being a C-. According to Kirk, the result should be a C. It wasn't. I found that the score coming into the method to make the display grade had the display scale applied to it and rounding, which knocked it down to 2 decimal places. This caused a failure, so I changed it to send into the convertPercentageToLetterGrade the fully precise number and that seemed to work fine.

I tried the other boundary case of 6 assignments, 3 grades being a B and 3 grades being a B+. This should result in a B+, but didn't. I found a precision issue with getPercentAsPointsEarned(Assignment assignment, Double percentage) in GradeCalculationsOOImpl. It was applying the math context in only one operation which seemed to really confuse it. I eliminated that and it seemed to work fine.

GRBK_668.csv is a csv import file used in a hosted mode import. I am setting the GB to letter grade no categories mode.