Issues

Select view

  • Select search mode

 
4 of 4

in drop lowest category, give ungraded no credit 0s, item appears dropped before it should be

Fixed

Description

DEV
SmartSite@UCDavis - 2.7.2.a3 - Sakai 2.7.1 - Server "ucdtest1"
grbk2
gradebook2 GB2 v1.5.0-b2 on smartsite-dev.rsmart.com

in regression testing, site CHE 118BA A03-A04 w11 weighted cats/points -
for a drop lowest 1 category, I designated 1 item as give ungraded no credit so all the students have an item grade of 0.
they get Fs, which is correct.
BUT
the item appears dropped (the 0 is red and crossed out) even for those who have no other graded items in the category.
nothing SHOULD be dropped until the number to be dropped is reached in the number graded.
see the images in grbk-942.

Details

Assignee

Reporter

QA Status

PASS

Components

Fix versions

Affects versions

Priority

Created May 13, 2011 at 7:01 PM
Updated May 28, 2011 at 11:59 AM
Resolved May 24, 2011 at 5:38 PM

Activity

David WoodsMay 28, 2011 at 11:59 AM

give ungraded no credit items are marked at appropriate times for drop lowest category, and included in calculations at appropriate times for drop lowest processing.

David WoodsMay 28, 2011 at 11:58 AM

QA Test
Firefox 3.6, Chrome 11
GB Version 1.5.0-b11

In new (yesterday) site, Weighted Categories/Points gradebook
Category with 9 equal weighted items
two items set to give zero when ungraded
drop lowest set to 4
as scores were added to a student, nothing was marked as dropped, or dropped from the calculations until the fifth score was added
using negative scores I verified that if there were 4 scores below 0 pts, then the 'give ungraded no credit' items were not dropped and were included in the calculation
took the 'give ungraded no credit' off of one of the two items and the grade calculations and scores dropped adjusted accordingly.

Marked the whole category as extra credit – all the drop markers were removed, and the scores calculated properly. When the extra credit option was turned off, all the drop markers returned in correct locations and the grade was recalculated appropriately.

The only problem visible is that the "-4" next to the category name in the structure did not disappear while the category was marked as extra credit. This is a cosmetic problem.

Results
drop lowest is correctly not taking effect until the number of scores for a student exceeds the drop number (meaning at least one score remains)
'give ungraded no credit' items are handled correctly in the drop lowest marking and calculations.

QA PASS

Michael WenkMay 24, 2011 at 5:38 PM

r74449

Michael WenkMay 24, 2011 at 5:37 PM

So as it turns out, I needed to keep track of the number of items that have graded regardless if the source of the "grade" was give ungraded no credit.

I unit tested this by:

WC with DL of 2 with 3 items, 1 item GUNC, and I didn't see the drop lowest take affect until all 3 items had grade.

WC with DL of 4 with 8 items, 2 items GUNC and 2 items graded, DL didn't hit until the 3 item grade entered(5 items total graded)

Michael WenkMay 24, 2011 at 3:31 PM

Yes it definitely looks like this was caused by GRBK-680. This problem is slightly intermittent. Grade and remove grades and it will then remove the isDropped from the markers.