CCFIT: 'give ungraded no credit' - Zeros given in scores not marked when dropped.
Description
Environment
Attachments
Activity
David Woods May 28, 2011 at 11:39 AM
'give ungraded no credit' items are marked as dropped or not marked as dropped at appropriate times when drop lowest is in effect.
'give ungraded no credit' items are included in the grade calculations or not included in the grade calculation at appropriate times when drop lowest is in effect.
David Woods May 28, 2011 at 11:35 AM
QA Test
Firefox 3.6, Chrome 11
GB Version 1.5.0-b11
In new (yesterday) site, Weighted Categories/Points gradebook
Category with 9 equal weighted items
two items set to give zero when ungraded
drop lowest set to 4
as scores were added to a student, nothing was marked as dropped, or dropped from the calculations until the fifth score was added
using negative scores I verified that if there were 4 scores below 0 pts, then the 'give ungraded no credit' items were not dropped and were included in the calculation
took the 'give ungraded no credit' off of one of the two items and the grade calculations and scores dropped adjusted accordingly.
Marked the whole category as extra credit – all the drop markers were removed, and the scores calculated properly. When the extra credit option was turned off, all the drop markers returned in correct locations and the grade was recalculated appropriately.
The only problem visible is that the "-4" next to the category name in the structure did not disappear while the category was marked as extra credit. This is a cosmetic problem.
Results
drop lowest is correctly not taking effect until the number of scores for a student exceeds the drop number (meaning at least one score remains)
'give ungraded no credit' items are handled correctly in the drop lowest marking and calculations.
QA PASS
Thomas Amsler May 5, 2011 at 9:47 AM
This has been merged into trunk @ r74059.
Thank you JIhane Najdi for your contribution!!
Former user May 5, 2011 at 5:39 AM
Updated patch for trunk.
Thomas Amsler May 4, 2011 at 11:34 PM
Code review is complete. There is one issue that needs to be addressed and then we are ready to merge this into trunk.
JIhane,
Can you please address the one issue as identified in the code review " http://codereview.appspot.com/4438084" and please provide a new patch that applies on trunk. Thank you.
--create a category with multiple items (equally weighted) and set to drop lowest score(s).
--enter non zero grades in multiple items for student – more than the number to be dropped, leaving at least one possible item ungraded
--note that the correct number of item scores are marked as dropped
--edit the definition of the ungraded item and mark it as 'give ungraded no credit'
--zero should appear for score of the marked item – and should be indicated as dropped –
the zero score appears to be dropped since an item previously marked as dropped is now marked as being used, but the zero score is not marked as dropped (i.e. not colored red with a crossout bar)