The TII code introduced filtering of the LTI launch parameters to ensure they are valid and didn't include the LTI Content Item parameters in the list of valid items. This results in LTI content item launches not working correctly as all the additional parameters are incorrectly prefixed with `custom_`
Activity
Show:
Brian Baillargeon June 8, 2017 at 9:41 AM
Validation of the LTI content properties doesn't really ring a bell. Not seeing any relevant results when I search the source for, say, 'validat'. Are you perhaps referring to the addTIIproperties method removed from BasicLTI here?: https://github.com/sakaicontrib/sakai-turnitin/pull/27/files
Matthew Buckett June 8, 2017 at 9:23 AM
I think there's still the call to validate the properties on an LTI launch isn't there, so I'm not sure it's fixed, just that the better fix might be to drop the validation?
Brian J. June 8, 2017 at 9:22 AM
Cool, so I think we can just close this as a non-issue.
Brian Baillargeon June 8, 2017 at 9:20 AM
I don't really have anything to add; just
Matthew Buckett June 8, 2017 at 9:04 AM
I don't like the validation of the properties and I wasn't sure if meant we could drop the validation of properties completely. Locally we aren't running so I fixed it before considering that.
The TII code introduced filtering of the LTI launch parameters to ensure they are valid and didn't include the LTI Content Item parameters in the list of valid items. This results in LTI content item launches not working correctly as all the additional parameters are incorrectly prefixed with `custom_`