Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Too many literal strings in citations code

Description

The identifiers for fields in the schema are scattered as literal strings in the code. Ideally these would be replaced with constants wherever possible.

Environment

None

Activity

Jim Eng October 26, 2006 at 12:40 PM

Gaurav, I'm assigning this one to you for now. Not sure whether this is for Phase 1, but I think the first step is to create a class/interface in Sakaibrary that defines all the rlevant strings. Then we need to change other classes in the osid impls and in the citations files to reference those string constants instead of using literal strings.

Jim Eng October 10, 2006 at 8:52 AM

All of the modules in the Sakaibrary project should reference the same string constants. All modules already depend on Sakaibrary-util-api, so putting this class there creates no new dependencies. Also, that's the most logical place for them.

Jim Eng October 10, 2006 at 8:47 AM

Need a class in Sakaibrary/util-api that defines string constants for all strings used in the out-of-band agreements for Sakaibrary's OSID impls. These strings will also be used by CitationService.

Won't Fix

Details

Assignee

Reporter

Components

Fix versions

Affects versions

Priority

Created October 10, 2006 at 7:33 AM
Updated May 20, 2010 at 11:28 AM
Resolved May 20, 2010 at 11:28 AM