Fix entity linking
Description
depends on
is related to
Activity
Brian J. November 19, 2019 at 10:34 AM
Discussed on the Core Team call this morning. Decision was made to bump https://sakaiproject.atlassian.net/browse/SAK-32130#icft=SAK-32130 to blocker priority for the 20.0 release. If it doesn't get addressed by the time the 20.0 tag is to be cut, we'll need to create and push scorm-api 20.0 artifact to OSSHR.
Also discussed adding this back to master with @Earle Nietzel, which he will do. The 21-SNAPSHOT artifact of scorm-api now exists in OSSHR, so the master build shouldn't be affected.
In the future, we're hoping to get https://sakaiproject.atlassian.net/browse/SAK-32130#icft=SAK-32130 addressed so that we don't have to be reliant on contrib artifacts being published for the core build to be successful (the provider pattern would eliminate the necessity for the text-area project to have dependencies on the APIs of the tools which have entity linking implemented).
Brian J. November 7, 2019 at 11:21 AM
@Earle Nietzel, I don't see the SCORM artifact in that chain of dependencies. What command do you use to identify this?
Earle Nietzel November 7, 2019 at 11:11 AM
Yeah you'll need to look a little deeper as the scorm-api creates a dependency on masters version.
org.sakaiproject:master:pom:21-SNAPSHOT -> ... -> org.sakaiproject:elfinder-connector:war:21-SNAPSHOT -> org.sakaiproject.samigo:samigo-api:jar:21-SNAPSHOT:provided -> org.sakaiproject:master:pom:21-SNAPSHOT
Which when they're not lined up the build will break, this is the issue. This is why never wise to include SNAPSHOT versions in master's dependencyManagement that are not generated by the build.
Brian J. November 7, 2019 at 10:54 AM
@Earle Nietzel, as far as I'm aware, it's not really a circular dependency. It's just that a core tool now has a dependency on a contrib artifact, which is why I had you give me access to Jenkins so that I could set up pipelines to push the scorm artifacts to OSSHR. I set up another one now, so we have artifacts for both 20-SNAPSHOT and 21-SNAPSHOT.
Given this, can we at least re-apply the commit you reverted as a stop-gap measure before some resources are allocated to SAK-32130?
Earle Nietzel November 7, 2019 at 9:40 AM
Hi Brian, completely agree with you nothing has changed! I would just like to solve the circular dependency that was created as it is an issue.
Entity linking no longer works in 20.x. When selecting 'browse server', the SCORM tool doesn't show up at all.
This is due to the switch in core Sakai from the EntityLinker to the elfinder plugin for CKEditor, and as such now requires code to be added to core Sakai.
There are also a few small changes to the SCORM entity provider due to the Wicket 8 upgrade in SCO-117.