Peer Review: 500 error if instructor clicks on any student other than the first one in the submission list
Description
Attachments
- 08 Jan 2025, 03:44 PM
- 02 Jan 2025, 10:37 PM
- 02 Jan 2025, 10:37 PM
- 02 Jan 2025, 10:37 PM
- 02 Jan 2025, 10:36 PM
depends on
Activity
Andrea Schmidt January 8, 2025 at 10:01 PM
Verified on 23x: https://qa23-maria.nightly.sakaiproject.org/, build: dcb4ca36
Andrea Schmidt January 8, 2025 at 3:44 PMEdited
This is failing on 23x…are there other Jiras that are needed that are not on 23x? Checked Jenkins to make sure this Jira is on 23x.
23x: https://qa23-maria.nightly.sakaiproject.org/, build: cc62c5b5
Am seeing the following in the server logs:
08-Jan-2025 10:35:36.417 WARN [http-nio-20023-exec-8] o.s.a.i.AssignmentServiceImpl.getContentReviewResults Retrieved null ContentReviewItem for content /attachment/de5991ba-96c7-4b12-9100-55bfee75ef0b/Assignments/98891330-5b03-435f-b53a-39f5c01d7975/InlineSub_dedc3964-a4e4-4f9c-a7c4-30c5a8f45cb5_johart_2025-01-08_10-12-56.html
08-Jan-2025 10:35:36.432 WARN [http-nio-20023-exec-8] o.s.a.i.AssignmentServiceImpl.getContentReviewResults Retrieved null ContentReviewItem for content /attachment/de5991ba-96c7-4b12-9100-55bfee75ef0b/Assignments/0578a0fc-de30-4941-819a-7da9453f77fd/PDF4.pdf
08-Jan-2025 10:35:36.441 WARN [http-nio-20023-exec-8] o.s.a.i.AssignmentServiceImpl.getContentReviewResults Retrieved null ContentReviewItem for content /attachment/de5991ba-96c7-4b12-9100-55bfee75ef0b/Assignments/986a918b-c760-4450-81c5-42f75ca6967a/InlineSub_dedc3964-a4e4-4f9c-a7c4-30c5a8f45cb5_rodell_2025-01-08_10-14-11.htmlAnd there are console errors:
While the 500 error is not present, the grading page does not load.
Andrea Schmidt January 4, 2025 at 5:05 PM
Verified on 25x: https://trunk-maria.nightly.sakaiproject.org/, build: 5278ec98
The grader loads regardless which student in the list is clicked and the student submission/attachment and the reviewer comments/attachments are present. Clicking on a reviewer’s attachment link opens the doc in a new tab.
There are no errors in the server logs now.
Earle Nietzel January 3, 2025 at 5:55 PM
When initializing SimplePeerAssessmentItem the
PeerAssessmentItem.attachmentRefList
may be null
Automation for Jira January 3, 2025 at 5:46 PM
A pull request has been created, "SAK-50810 Assignment in peer review attachmentRefList maybe null", you can see it at https://github.com/sakaiproject/sakai/pull/13149
Details
Details
Priority
Blocker
With a peer review assignment, when the instructor tries to grade and clicks any name other than the very first one in the submission list, the grader never loads and here are console errors and a stacktrace. I am not seeing this issue for a regular assignment that is not a peer review.
Possibly related to https://sakaiproject.atlassian.net/browse/SAK-50660
Console errors:
sakai-gradable-data-mixin.js:15 GET https://trunk-maria.nightly.sakaiproject.org/direct/assignment/gradable.jso…e-4cb4-b4f5-0b58459521f0&submissionId=2ce0bf97-49b5-49cb-9fa8-1bf7541901c7 500 (Internal Server Error) sakai-gradable-data-mixin.js:75 Error: Network error while loading gradable from /direct/assignment/gradable.json?gradableId=bb451149-961e-4cb4-b4f5-0b58459521f0&submissionId=2ce0bf97-49b5-49cb-9fa8-1bf7541901c7 at sakai-gradable-data-mixin.js:21:15Stacktrace (attaching file for full info):
02-Jan-2025 17:18:03.232 ERROR [http-nio-20313-exec-20] o.s.e.r.EntityActionsManager.handleCustomActionExecution Target exception class not identified, rethrowing as a RuntimeException: java.lang.NullPointerException: Cannot invoke "java.util.List.stream()" because the return value of "org.sakaiproject.assignment.api.model.PeerAssessmentItem.getAttachmentRefList()" is null02-Jan-2025 17:18:03.234 ERROR [http-nio-20313-exec-20] o.s.e.i.e.SakaiExternalIntegrationProvider.handleEntityError Direct request failure: RuntimeException:Fatal error trying to execute custom action method: gradable:list:getGradableForSite:Direct request failure: RuntimeException:Fatal error trying to execute custom action method: gradable:list:getGradableForSite: Sakai version: 25-SNAPSHOT(2479faa5)