Assignments-Grader: Grader fails to load with corrupted file submissions

Description

The new Sakai grader breaks when a submission contains corrupted files, resulting in a 404 error. In contrast, the classic grader successfully filtered out these corrupted files. The new grader, however, does not, and gets stuck on the message:

'Loading the grading data... This may take a few seconds.'

Activity

Show:

Bernardo Garcia Vila November 8, 2024 at 10:55 AM

Yes, I agree that something should be done for that too, but at the same time imagine there’s a temporary error accessing the NFS and you get a 404. If that’s the case and we add some logic to clean up files that throw a 404, then it might actually remove files that are just unavailable for a short span of time and the consequences would be much worse.

So maybe something like a WS or a job that can be executed under control to clean up would make more sense, but that’s obviously out of the scope of this fix. This was just to allow users to access the new grader like the old one.

Adrian Fish October 30, 2024 at 4:24 PM

If we have a corrupted file like this, how do we deal with it? Do we just leave an assignment submission with a missing or corrupted file? I’m just asking generally, because it seems incorrect to just leave these broken pieces of data lying around and code around the problem.

Automation for Jira October 28, 2024 at 1:17 PM

A pull request has been created, "SAK-50646 Assignments-Grader: Grader fails to load with corrupted file submissions", you can see it at https://github.com/sakaiproject/sakai/pull/12991

Fixed

Details

Priority

Fix versions

Components

Assignee

Reporter

Created October 28, 2024 at 12:16 PM
Updated November 19, 2024 at 12:02 AM
Resolved October 31, 2024 at 7:27 AM