LTI 1.3 Synchronizing grades doesn't work well when Tomcat language's decimal separator is a comma

GENERAL

TESTING

GENERAL

TESTING

Description

We have experienced this issue testing the platforms H5P and Wooclap via LTI integration.

When grades are synchronized with Gradebook the grade is only correctly written in Gradebook if Tomcat's locale has the point as decimal separator. If Tomcat's locale has the comma as decimal separator (i.e. in spanish, french...) the grades are multiplied by 10 (because points are ignored and 1.0 is changed by 10)

I have applied a fix copied from Gradebook's code and it works. It's just adding this code in SakaiBLTIUtil.java in getRoundedGrade() method:

String gradeI18n = String.valueOf(theGrade);
		FormattedText formattedText = ComponentManager.get(FormattedText.class);
		if (",".equals(formattedText.getDecimalSeparator())) gradeI18n = gradeI18n.replace(".",",");
		return gradeI18n;

This works in my test server with spanish and US english locales.

Before doing a PR I would like to know if this solution is acceptable.

Linked issues

is related to

SAK-45009

Synchronizing grades doesn't work well when Tomcat language's decimal separator is a comma

Activity

Show:

Automation for Jira October 18, 2024 at 8:35 AM

A pull request has been created, "SAK-50616 LTI 1.3 Synchronizing grades doesn't work well when Tomcat language's decimal separator is a comma", you can see it at https://github.com/sakaiproject/sakai/pull/12971