Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Unnecesary call to function in EventLogConverter

Description

https://sakaiproject.atlassian.net/browse/SAK-49506 added translation for events in Samigo.

To maintain retrocompatibility it determines if the text retrieved from database is a key or a value. If it’s a key it gets the value from properties.

However it always tries to get the value from properties without looking if it’s a key, so an unnecesary call is done. Even worse, that call writes an error line in Tomcat’s logs.

java.util.MissingResourceException: Can't find resource for bundle java.util.PropertyResourceBundle, key Sin errores (El usuario envió)

A very simple change can fix this.

Activity

Show:

Automation for Jira October 17, 2024 at 1:48 PM

A pull request has been created, "SAK-50614 - Unnecesary call to translation", you can see it at https://github.com/sakaiproject/sakai/pull/12969

Fixed

Details

Priority

Affects versions

Fix versions

23 Status

Please Merge

22 Status

Please Merge

Components

Assignee

Reporter

Labels

Created October 17, 2024 at 1:42 PM
Updated October 21, 2024 at 11:05 PM
Resolved October 21, 2024 at 11:05 PM
Configure

Flag notifications