Lessons: printing of lesson pages does include unwanted elements

Description

Steps to reproduce

  • Go to site with lessons tool

  • Choose a lessons page with some content

  • Click on print view | print all → Ctrl + P → e.g. Save to PDF

  • the generated PDF does include many unwanted elements of the DOM → see attachement

Attachments

5

Activity

Show:

Wasi Khan October 31, 2024 at 4:52 PM

Wasi Khan October 31, 2024 at 1:20 AM

Verified on trunk, the overkill buttons have disappeared. Tested on the following content:

  • checklist

  • add text

  • add question

  • linked assignment

  • linked quiz

  • content link

A small nuance is that column breaks are not printed correctly on pdf - but that is a separate issue since I imagine a lot of the code will change on how pdfs will print when split into columns. Hence, will create a new Jira and link it to this one.

Andrea Schmidt October 17, 2024 at 9:45 PM

Verified , so this is now fine too: 25x: https://trunk-maria.nightly.sakaiproject.org/, build: 60bf216b

Sam Ottenhoff October 15, 2024 at 5:47 PM

I created a new issue for quicklinks:

Andrea Schmidt October 14, 2024 at 10:51 PM

Tested on 25x: https://trunk-maria.nightly.sakaiproject.org/, build: 1a1c548e

Am now on Win11, tested Edge and Firefox. Only one print button is available and it works now in Firefox also.

The bad news is that there is still “extra” stuff on the print page:

was this to be removed?

Fixed

Details

Priority

23 Status

QA Verification Pass

22 Status

Please Merge

21 Status

Please Merge

Components

Assignee

Reporter

Created September 11, 2024 at 9:22 AM
Updated October 31, 2024 at 4:52 PM
Resolved October 13, 2024 at 10:21 PM